Skip to content

Commit 0980a21

Browse files
committed
Fix checking state cache (fix actions#1136), also switch to octokit methods
1 parent 3f3b017 commit 0980a21

File tree

2 files changed

+24
-14
lines changed

2 files changed

+24
-14
lines changed

dist/index.js

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1618,9 +1618,13 @@ const getOctokitClient = () => {
16181618
const checkIfCacheExists = (cacheKey) => __awaiter(void 0, void 0, void 0, function* () {
16191619
const client = getOctokitClient();
16201620
try {
1621-
const issueResult = yield client.request(`/repos/${github_1.context.repo.owner}/${github_1.context.repo.repo}/actions/caches`);
1622-
const caches = issueResult.data['actions_caches'] || [];
1623-
return Boolean(caches.find(cache => cache['key'] === cacheKey));
1621+
const cachesResult = yield client.rest.actions.getActionsCacheList({
1622+
owner: github_1.context.repo.owner,
1623+
repo: github_1.context.repo.repo,
1624+
key: cacheKey, // prefix matching
1625+
});
1626+
const caches = cachesResult.data['actions_caches'] || [];
1627+
return caches.some(cache => cache['key'] === cacheKey);
16241628
}
16251629
catch (error) {
16261630
core.debug(`Error checking if cache exist: ${error.message}`);
@@ -1631,8 +1635,11 @@ const resetCacheWithOctokit = (cacheKey) => __awaiter(void 0, void 0, void 0, fu
16311635
const client = getOctokitClient();
16321636
core.debug(`remove cache "${cacheKey}"`);
16331637
try {
1634-
// TODO: replace with client.rest.
1635-
yield client.request(`DELETE /repos/${github_1.context.repo.owner}/${github_1.context.repo.repo}/actions/caches?key=${cacheKey}`);
1638+
yield client.rest.actions.deleteActionsCacheByKey({
1639+
owner: github_1.context.repo.owner,
1640+
repo: github_1.context.repo.repo,
1641+
key: cacheKey,
1642+
});
16361643
}
16371644
catch (error) {
16381645
if (error.status) {

src/classes/state/state-cache-storage.ts

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,14 @@ const getOctokitClient = () => {
3333
const checkIfCacheExists = async (cacheKey: string): Promise<boolean> => {
3434
const client = getOctokitClient();
3535
try {
36-
const issueResult = await client.request(
37-
`/repos/${context.repo.owner}/${context.repo.repo}/actions/caches`
38-
);
36+
const cachesResult = await client.rest.actions.getActionsCacheList({
37+
owner: context.repo.owner,
38+
repo: context.repo.repo,
39+
key: cacheKey, // prefix matching
40+
});
3941
const caches: Array<{key?: string}> =
40-
issueResult.data['actions_caches'] || [];
41-
return Boolean(caches.find(cache => cache['key'] === cacheKey));
42+
cachesResult.data['actions_caches'] || [];
43+
return caches.some(cache => cache['key'] === cacheKey);
4244
} catch (error) {
4345
core.debug(`Error checking if cache exist: ${error.message}`);
4446
}
@@ -48,10 +50,11 @@ const resetCacheWithOctokit = async (cacheKey: string): Promise<void> => {
4850
const client = getOctokitClient();
4951
core.debug(`remove cache "${cacheKey}"`);
5052
try {
51-
// TODO: replace with client.rest.
52-
await client.request(
53-
`DELETE /repos/${context.repo.owner}/${context.repo.repo}/actions/caches?key=${cacheKey}`
54-
);
53+
await client.rest.actions.deleteActionsCacheByKey({
54+
owner: context.repo.owner,
55+
repo: context.repo.repo,
56+
key: cacheKey,
57+
});
5558
} catch (error) {
5659
if (error.status) {
5760
core.warning(

0 commit comments

Comments
 (0)