Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow curse forge mod files to be downloaded separately #3150

Open
TheAceMan opened this issue Nov 12, 2024 · 2 comments
Open

Allow curse forge mod files to be downloaded separately #3150

TheAceMan opened this issue Nov 12, 2024 · 2 comments

Comments

@TheAceMan
Copy link

Enhancement Type

Improve an existing feature

Describe the enhancement

Modpack has logic to use the CF_DOWNLOADS_REPO and install mods that do not allow automated downloads from a downloads folder. But individual mods supplied to CURSEFORGE_FILES do not allow this. As a workaround it appears that manually downloading the file and placing it in the mods folder does work. But for re-usability it would be nice to allow it to look locally for the file and not have to worry about it when creating a new server.

@rhullah
Copy link
Contributor

rhullah commented Nov 12, 2024

There were changes done to the image (earlier this year?) to get around the blocked mods and to download them w/out issue. I honestly cannot remember the last time I've seen the table of mods that needed to be manually downloaded because it should be able to download them now.

Have you pulled the latest image recently? What mod is it not able to auto download?

@TheAceMan
Copy link
Author

@rhullah I am using the helm chart and deploying tag: itzg/minecraft-server:2024.10.2-java17

Parts of the helm chart:

minecraftServer:
  version: "1.20.1"
  type: "AUTO_CURSEFORGE"
  autoCurseForge:
    apiKey:
      existingSecret: "minecraft-secret"
      secretKey: "cf_api_key"
    slug: "create-and-farmers-delight"

extraEnv:
  CURSEFORGE_FILES: |
    https://www.curseforge.com/minecraft/mc-mods/craftable-smithing-templates-armor-trims

As you suggest there are files in the modpack that do not allow automated downloads that are downloading fine. It's when I want to add an additional mod in addition to the modpack. Maybe this is not the correct or supported way to do this?

NOTE if you do test the above, there is a broken mod (AverageAnime/create-food#1) in the modpack that I do need to also use the CF_DOWNLOADS_REPO: /data/downloads to get around. But you should be able to use any modpack to replicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants