Skip to content

Commit 76f615f

Browse files
committed
Revert "Add arrow glyphs jupyterlab#151"
This reverts commit 57a6ee7. It was not clear in issue jupyterlab#151 calling for a change in formatting of arrows that arrows should not be treated as modifier keys.
1 parent 0f7378b commit 76f615f

File tree

1 file changed

+1
-55
lines changed

1 file changed

+1
-55
lines changed

packages/commands/src/index.ts

Lines changed: 1 addition & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -1062,26 +1062,6 @@ export namespace CommandRegistry {
10621062
*/
10631063
shift: boolean;
10641064

1065-
/**
1066-
* Whether `'ArrowLeft'` appears in the keystroke.
1067-
*/
1068-
arrowLeft: boolean;
1069-
1070-
/**
1071-
* Whether `'ArrowUp'` appears in the keystroke.
1072-
*/
1073-
arrowUp: boolean;
1074-
1075-
/**
1076-
* Whether `'ArrowRight'` appears in the keystroke.
1077-
*/
1078-
arrowRight: boolean;
1079-
1080-
/**
1081-
* Whether `'ArrowDown'` appears in the keystroke.
1082-
*/
1083-
arrowDown: boolean;
1084-
10851065
/**
10861066
* The primary key for the keystroke.
10871067
*/
@@ -1116,10 +1096,6 @@ export namespace CommandRegistry {
11161096
let cmd = false;
11171097
let ctrl = false;
11181098
let shift = false;
1119-
let arrowLeft = false;
1120-
let arrowUp = false;
1121-
let arrowRight = false;
1122-
let arrowDown = false;
11231099
for (let token of keystroke.split(/\s+/)) {
11241100
if (token === 'Accel') {
11251101
if (Platform.IS_MAC) {
@@ -1135,29 +1111,11 @@ export namespace CommandRegistry {
11351111
ctrl = true;
11361112
} else if (token === 'Shift') {
11371113
shift = true;
1138-
} else if (token === 'ArrowLeft') {
1139-
arrowLeft = true;
1140-
} else if (token === 'ArrowUp') {
1141-
arrowUp = true;
1142-
} else if (token === 'ArrowRight') {
1143-
arrowRight = true;
1144-
} else if (token === 'ArrowDown') {
1145-
arrowDown = true;
11461114
} else if (token.length > 0) {
11471115
key = token;
11481116
}
11491117
}
1150-
return {
1151-
cmd,
1152-
ctrl,
1153-
alt,
1154-
shift,
1155-
key,
1156-
arrowLeft,
1157-
arrowUp,
1158-
arrowRight,
1159-
arrowDown
1160-
};
1118+
return { cmd, ctrl, alt, shift, key };
11611119
}
11621120

11631121
/**
@@ -1229,18 +1187,6 @@ export namespace CommandRegistry {
12291187
if (parts.cmd) {
12301188
mods += '\u2318 ';
12311189
}
1232-
if (parts.arrowLeft) {
1233-
mods += '\u2190 ';
1234-
}
1235-
if (parts.arrowUp) {
1236-
mods += '\u2191 ';
1237-
}
1238-
if (parts.arrowRight) {
1239-
mods += '\u2192 ';
1240-
}
1241-
if (parts.arrowDown) {
1242-
mods += '\u2193 ';
1243-
}
12441190
} else {
12451191
if (parts.ctrl) {
12461192
mods += 'Ctrl+';

0 commit comments

Comments
 (0)