Skip to content

Commit f0277a0

Browse files
Merge pull request GoogleCloudPlatform#2938 from jasonvigil/enable-sqlinstance-denymaintenanceperiod-nochange
fix: Enable sqlinstance-denymaintenanceperiod nochange test
2 parents ae7a452 + b34f4cd commit f0277a0

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

pkg/test/resourcefixture/contexts/sql_context.go

-4
Original file line numberDiff line numberDiff line change
@@ -196,17 +196,13 @@ func init() {
196196
}
197197

198198
resourceContextMap["sqlinstance-denymaintenanceperiod"] = ResourceContext{
199-
// TODO: Remove after switching to use direct controller.
200-
SkipNoChange: true,
201199
// SQL instances appear to need a bit of additional time before attempting to recreate
202200
// with the exact same name. Otherwise, the GCP API returns "unknown error".
203201
RecreateDelay: time.Second * 60,
204202
ResourceKind: "SQLInstance",
205203
}
206204

207205
resourceContextMap["sqlinstance-denymaintenanceperiod-direct"] = ResourceContext{
208-
// TODO: Remove after switching to use direct controller.
209-
SkipNoChange: true,
210206
// SQL instances appear to need a bit of additional time before attempting to recreate
211207
// with the exact same name. Otherwise, the GCP API returns "unknown error".
212208
RecreateDelay: time.Second * 60,

0 commit comments

Comments
 (0)