chore: add TODO

Author: Piotr Kubicki

api/openapi.yml

@@ -184,8 +184,8 @@ components:
       type: object
       properties:
         id:
-          type: string
-          format: uuid
+          type: string # TODO integer
+          format: uuid # TODO int64 -> Krzysztof - change uuid to integer or something better suited for long for Long id of Entity. Change all uuid and resign from getMostSignificantBits everywhere
         name:
           type: string
         duration:

src/main/java/com/capgemini/training/appointmentbooking/dataaccess/repository/AppointmentRepository.java

@@ -78,7 +78,7 @@ SELECT CASE WHEN COUNT(a) > 0 THEN TRUE ELSE FALSE END
             WHERE t.specialist.id = :specialistId 
             AND a.dateTime = :date
             AND a.status <> com.capgemini.training.appointmentbooking.common.datatype.AppointmentStatus.CANCELLED
-            """)
+            """) // TODO add checks for TreatmentEntity#durationMinutes so that within treatment time no more appoinments can be booked
     boolean hasConflictingAppointmentBySpecialistIdAndDateTime(@Param("specialistId") Long specialistId, @Param("date") Instant date);
 
 }

src/main/java/com/capgemini/training/appointmentbooking/dataaccess/repository/UserRepository.java

@@ -15,7 +15,7 @@
 
 @Repository
 public interface UserRepository extends BaseJpaRepository<UserEntity, Long> {
-    default List<UserEntity> findByCriteria(UserCriteria criteria) {
+    default List<UserEntity> findByCriteria(UserCriteria criteria) { // TODO openapi change ? -> szukanie po clientach do stworzenia appointmentów
         Objects.requireNonNull(criteria, "criteria must not be null");
 
         EntityManager entityManager = getEntityManager();

src/main/java/com/capgemini/training/appointmentbooking/logic/impl/ManageAppointmentUcImpl.java

@@ -53,13 +53,13 @@ public ManageAppointmentUcImpl(FindAppointmentUc findAppointmentUc, AppointmentR
     @Override
     public AppointmentCto bookAppointment(@Valid AppointmentBookingEto appointmentBookingEto) {
         boolean hasConflict = findAppointmentUc.hasConflictingAppointment(appointmentBookingEto.specialistId(), appointmentBookingEto.dateTime());
-
+        // TODO Michał will add hints regarding pessimistic locking in exercise for logic
         if (hasConflict) {
             throw new ConflictedAppointmentException();
         }
 
         AppointmentEntity appointmentEntity = buildAppointmentEntity(appointmentBookingEto);
-        appointmentEntity = appointmentRepository.saveAndFlush(appointmentEntity);
+        appointmentEntity = appointmentRepository.saveAndFlush(appointmentEntity); // TODO Piotr save
 
         return appointmentCtoMapper.toCto(appointmentEntity);
     }
@@ -71,15 +71,15 @@ public AppointmentEto updateAppointmentStatus(@NotNull Long appointmentId, @NotN
                 .orElseThrow(() -> new EntityNotFoundException("Appointment not found for ID: " + appointmentId));
 
         appointmentEntity.setStatus(appointmentStatus);
-        appointmentEntity = appointmentRepository.saveAndFlush(appointmentEntity);
+        appointmentEntity = appointmentRepository.saveAndFlush(appointmentEntity); // TODO Piotr save
 
         return appointmentMapper.toEto(appointmentEntity);
     }
 
     private AppointmentEntity buildAppointmentEntity(@Valid AppointmentBookingEto appointmentBookingEto) {
         AppointmentEntity entity = new AppointmentEntity();
 
-        ClientEntity clientEntity = clientRepository.getReferenceById(appointmentBookingEto.clientId());
+        ClientEntity clientEntity = clientRepository.getReferenceById(appointmentBookingEto.clientId()); // TODO change getReferenceById to find
         TreatmentEntity treatmentEntity = treatmentRepository.getReferenceById(appointmentBookingEto.treatmentId());
 
         entity.setClient(clientEntity);

src/main/java/com/capgemini/training/appointmentbooking/service/impl/AppointmentsApiController.java

@@ -45,7 +45,7 @@ public ResponseEntity<List<Appointment>> getAppointments(
     AppointmentCriteria.AppointmentCriteriaBuilder criteria = AppointmentCriteria.builder();
     status.ifPresent(t -> criteria.status(AppointmentStatus.valueOf(t)));
     clientId.ifPresent(t -> criteria.clientId(UUID.fromString(t).getMostSignificantBits()));
-    specialistId.ifPresent(t -> criteria.specialistId(UUID.fromString(t).getMostSignificantBits()));
+    specialistId.ifPresent(t -> criteria.specialistId(UUID.fromString(t).getMostSignificantBits())); // TODO Krzysztof resign from getMostSignificantBits everywhere, instewad of uuid we want integer
 
     List<AppointmentCto> list = findAppointmentUc.findByCriteria(criteria.build());
     List<Appointment> result =