Review

Author: michalluzyna

src/main/java/com/capgemini/training/appointment_booking_app/common/converter/SpecializationConverter.java

@@ -1,5 +1,7 @@
 package com.capgemini.training.appointment_booking_app.common.converter;
-
+/*
+Review: znaki _ nie powinny się znajdować w nazwie pakietu, jest to zależność do persistance
+ */
 import com.capgemini.training.appointment_booking_app.common.datatype.Specialization;
 
 import jakarta.persistence.AttributeConverter;

src/main/java/com/capgemini/training/appointment_booking_app/dataaccess/entity/AppointmentEntity.java

@@ -17,23 +17,24 @@
 import lombok.Getter;
 import lombok.Setter;
 
+// Review uważam że dobrą praktyką jest wprowadzenie bazowej klassy wykorzystując @MappedSuperclass
 @Entity
 @Table(name="APPOINTMENT")
 @Getter
 @Setter
 public class AppointmentEntity {
 
 	@Id
-	@GeneratedValue(strategy = GenerationType.IDENTITY)
+	@GeneratedValue(strategy = GenerationType.IDENTITY) // review why not sequence?
 	private Long id;
 
 	@Version
 	private int version;
 
-	@ManyToOne
+	@ManyToOne // review lazy
 	private ClientEntity client;
 
-	@ManyToOne
+	@ManyToOne // review lazy
 	private TreatmentEntity treatment;
 
 	@Column(name="DATE_TIME")

src/main/java/com/capgemini/training/appointment_booking_app/dataaccess/entity/ClientEntity.java

@@ -26,10 +26,10 @@ public class ClientEntity {
 
 	@Version
 	private int version;
-	
+	// review lazy, cascade only persist
 	@OneToOne(optional = false, cascade = { CascadeType.PERSIST, CascadeType.MERGE, CascadeType.REMOVE })
 	private UserEntity user;
-	
+	// review lazy, cascade only persist
 	@OneToMany(mappedBy = "client", orphanRemoval=true, cascade = { CascadeType.PERSIST, CascadeType.MERGE, CascadeType.REMOVE })
 	private List<AppointmentEntity> appointments;
 

src/main/java/com/capgemini/training/appointment_booking_app/dataaccess/entity/SpecialistEntity.java

@@ -33,13 +33,13 @@ public class SpecialistEntity {
 
 	@Version
 	private int version;
-	
+	// review lazy
 	@OneToOne(optional = false)
 	private UserEntity user;
 
 	@Convert(converter = SpecializationConverter.class)
 	private Specialization specialization;
-	
+	// review lazy, cascade only persist
 	@OneToMany(mappedBy = "specialist", cascade = { CascadeType.PERSIST, CascadeType.MERGE, CascadeType.REMOVE })
 	private List<TreatmentEntity> treatments;
 }

src/main/java/com/capgemini/training/appointment_booking_app/dataaccess/entity/TreatmentEntity.java

@@ -30,7 +30,7 @@ public class TreatmentEntity {
 
 	@Column(name="DURATION_MINUTES")
 	private int durationMinutes;
-	
+	// review lazy
 	@ManyToOne
 	private SpecialistEntity specialist;
 

src/main/resources/db/migration/1.0/V0001__Create_schema.sql

@@ -1,10 +1,16 @@
+/**
+Review
+1. Autoinkrement, nie zalecam
+2. Zróbmy sekwencje dla tabel
+3. cascade delete - nie zawsze rozważne
+*/
 CREATE TABLE USER_TABLE (
 ID NUMBER(19,0) NOT NULL AUTO_INCREMENT,
 VERSION INTEGER NOT NULL,
-EMAIL VARCHAR(128),
-PASSWORD_HASH VARCHAR(128),
-FIRST_NAME VARCHAR(128),
-LAST_NAME VARCHAR(128),
+EMAIL VARCHAR(128), -- review not null?
+PASSWORD_HASH VARCHAR(128), -- review not null?
+FIRST_NAME VARCHAR(128), -- review not null?
+LAST_NAME VARCHAR(128), -- review not null?
 PRIMARY KEY (ID),
 CONSTRAINT UNIQUE_USER_EMAIL UNIQUE (EMAIL)
 );
@@ -20,7 +26,7 @@ FOREIGN KEY (USER_ID) REFERENCES USER_TABLE(ID) ON DELETE CASCADE
 CREATE TABLE SPECIALIST (
 ID NUMBER(19,0) NOT NULL AUTO_INCREMENT,
 VERSION INTEGER NOT NULL,
-SPECIALIZATION VARCHAR(128),
+SPECIALIZATION VARCHAR(128), -- review not null
 USER_ID NUMBER(19,0) NOT NULL,
 PRIMARY KEY (ID),
 FOREIGN KEY (USER_ID) REFERENCES USER_TABLE(ID) ON DELETE CASCADE
@@ -29,10 +35,10 @@ FOREIGN KEY (USER_ID) REFERENCES USER_TABLE(ID) ON DELETE CASCADE
 CREATE TABLE TREATMENT (
 ID NUMBER(19,0) NOT NULL AUTO_INCREMENT,
 VERSION INTEGER NOT NULL,
-NAME VARCHAR(256),
+NAME VARCHAR(256), -- review not null?
 DESCRIPTION VARCHAR(1024),
-DURATION_MINUTES INTEGER,
-SPECIALIST_ID NUMBER(19,0),
+DURATION_MINUTES INTEGER, -- review not null?
+SPECIALIST_ID NUMBER(19,0), -- review can be null?
 PRIMARY KEY (ID),
 FOREIGN KEY (SPECIALIST_ID) REFERENCES SPECIALIST(ID) ON DELETE CASCADE
 );
@@ -41,7 +47,7 @@ FOREIGN KEY (SPECIALIST_ID) REFERENCES SPECIALIST(ID) ON DELETE CASCADE
 CREATE TABLE APPOINTMENT (
 ID NUMBER(19,0) NOT NULL AUTO_INCREMENT,
 VERSION INTEGER NOT NULL,
-DATE_TIME TIMESTAMP,
+DATE_TIME TIMESTAMP, -- review might be null?
 STATUS VARCHAR(128) NOT NULL DEFAULT 'SCHEDULED',
 CLIENT_ID NUMBER(19,0) NOT NULL,
 TREATMENT_ID NUMBER(19,0) NOT NULL,