feat: add spotless, change name from EntitySmokeTest to EntitySmokeIT, cleanup

Author: Piotr Kubicki

pom.xml

@@ -124,6 +124,24 @@
 					<aggregate>true</aggregate>
 				</configuration>
 			</plugin>
+			<plugin>
+				<groupId>com.diffplug.spotless</groupId>
+				<artifactId>spotless-maven-plugin</artifactId>
+				<version>2.43.0</version>
+				<configuration>
+					<java>
+						<removeUnusedImports/>
+						<eclipse/>
+					</java>
+				</configuration>
+				<executions>
+					<execution>
+						<goals>
+							<goal>check</goal>
+						</goals>
+					</execution>
+				</executions>
+			</plugin>
 		</plugins>
 	</build>
 

src/main/java/com/capgemini/training/appointmentbooking/common/datatype/AppointmentStatus.java

@@ -1,5 +1,5 @@
 package com.capgemini.training.appointmentbooking.common.datatype;
 
 public enum AppointmentStatus {
-SCHEDULED, CANCELLED, COMPLETED;
+	SCHEDULED, CANCELLED, COMPLETED
 }

src/main/java/com/capgemini/training/appointmentbooking/common/datatype/Specialization.java

@@ -1,25 +1,20 @@
 package com.capgemini.training.appointmentbooking.common.datatype;
 
+import lombok.Getter;
+
+@Getter
 public enum Specialization {
-	
-	DENTIST("Dentist"), 
-	CARDIOLOGIST("Cardiologist"), 
-	PEDIATRICIAN("Pediatrician"), 
-	UROLOGIST("Urologist"), 
-	NEUROLOGIST("Neurologist"), 
-	ORTHOPAEDIST("Orthopaedist");
-	
-	private String name;
-
-	private Specialization(String name) {
+
+	DENTIST("Dentist"), CARDIOLOGIST("Cardiologist"), PEDIATRICIAN("Pediatrician"), UROLOGIST("Urologist"), NEUROLOGIST(
+			"Neurologist"), ORTHOPAEDIST("Orthopaedist");
+
+	private final String name;
+
+	Specialization(String name) {
 		this.name = name;
 	}
 
-	public String getName() {
-		return this.name;
-	}
-	
-	public static Specialization getByName(String name) {
+    public static Specialization getByName(String name) {
 
 		for (Specialization s : Specialization.values()) {
 			if (s.getName().equals(name)) {
@@ -28,5 +23,5 @@ public static Specialization getByName(String name) {
 		}
 		return null;
 	}
-	
+
 }

src/main/java/com/capgemini/training/appointmentbooking/dataaccess/converter/SpecializationConverter.java

@@ -9,17 +9,17 @@ public class SpecializationConverter implements AttributeConverter<Specializatio
 
 	@Override
 	public String convertToDatabaseColumn(Specialization specialization) {
-		
+
 		return specialization != null ? specialization.getName() : null;
-		
+
 	}
 
 	@Override
-    public Specialization convertToEntityAttribute(String dbData) {
-        if (dbData == null) {
-            return null;
-        }
-        return Specialization.getByName(dbData);
-    }
+	public Specialization convertToEntityAttribute(String dbData) {
+		if (dbData == null) {
+			return null;
+		}
+		return Specialization.getByName(dbData);
+	}
 
 }

src/main/java/com/capgemini/training/appointmentbooking/dataaccess/entity/AppointmentEntity.java

@@ -19,26 +19,26 @@
 import lombok.Setter;
 
 @Entity
-@Table(name="APPOINTMENT")
+@Table(name = "APPOINTMENT")
 @Getter
 @Setter
 public class AppointmentEntity extends BaseEntity {
-	
+
 	@Id
 	@GeneratedValue(strategy = GenerationType.SEQUENCE, generator = "APPOINTMENT_SEQ_GEN")
-	@SequenceGenerator(sequenceName = "APPOINTMENT_SEQ", name = "APPOINTMENT_SEQ_GEN", allocationSize = 100, initialValue = 1)
+	@SequenceGenerator(sequenceName = "APPOINTMENT_SEQ", name = "APPOINTMENT_SEQ_GEN", allocationSize = 100)
 	private Long id;
-	
+
 	@ManyToOne(fetch = FetchType.LAZY)
 	private ClientEntity client;
-	
+
 	@ManyToOne(fetch = FetchType.LAZY)
 	private TreatmentEntity treatment;
-	
-	@Column(name="DATE_TIME")
+
+	@Column(name = "DATE_TIME")
 	private Instant dateTime;
-	
+
 	@Enumerated(EnumType.STRING)
 	private AppointmentStatus status;
-	
+
 }

src/main/java/com/capgemini/training/appointmentbooking/dataaccess/entity/BaseEntity.java

@@ -1,7 +1,6 @@
 package com.capgemini.training.appointmentbooking.dataaccess.entity;
 
 import java.time.Instant;
-import java.util.Date;
 
 import jakarta.persistence.Column;
 import jakarta.persistence.MappedSuperclass;
@@ -14,24 +13,24 @@
 @MappedSuperclass
 @Getter
 public class BaseEntity {
-	
+
 	@Version
 	@Setter
 	private int version;
 
-	@Column(insertable = true, updatable = false)
+	@Column(updatable = false)
 	private Instant created;
-	
-	@Column(name="LAST_UPDATED")
+
+	@Column(name = "LAST_UPDATED")
 	private Instant lastUpdated;
-	
+
 	@PrePersist
 	public void prePersist() {
 		Instant now = Instant.now();
 		this.created = now;
 		this.lastUpdated = now;
 	}
-	
+
 	@PreUpdate
 	public void preUpdate() {
 		this.lastUpdated = Instant.now();

src/main/java/com/capgemini/training/appointmentbooking/dataaccess/entity/ClientEntity.java

@@ -16,20 +16,21 @@
 import lombok.Setter;
 
 @Entity
-@Table(name="CLIENT")
+@Table(name = "CLIENT")
 @Getter
 @Setter
-public class ClientEntity  extends BaseEntity {
-	
+public class ClientEntity extends BaseEntity {
+
 	@Id
 	@GeneratedValue(strategy = GenerationType.SEQUENCE, generator = "CLIENT_SEQ_GEN")
-	@SequenceGenerator(sequenceName = "CLIENT_SEQ", name = "CLIENT_SEQ_GEN", allocationSize = 100, initialValue = 1)
+	@SequenceGenerator(sequenceName = "CLIENT_SEQ", name = "CLIENT_SEQ_GEN", allocationSize = 100)
 	private Long id;
-	
-	@OneToOne(optional = false, fetch = FetchType.LAZY, cascade = { CascadeType.PERSIST })
+
+	@OneToOne(optional = false, fetch = FetchType.LAZY, cascade = {CascadeType.PERSIST})
 	private UserEntity user;
-	
-	@OneToMany(mappedBy = "client", fetch = FetchType.LAZY, orphanRemoval=true, cascade = { CascadeType.PERSIST, CascadeType.REMOVE })
+
+	@OneToMany(mappedBy = "client", fetch = FetchType.LAZY, orphanRemoval = true, cascade = {CascadeType.PERSIST,
+			CascadeType.REMOVE})
 	private List<AppointmentEntity> appointments;
-	
+
 }

src/main/java/com/capgemini/training/appointmentbooking/dataaccess/entity/SpecialistEntity.java

@@ -20,22 +20,23 @@
 import lombok.Setter;
 
 @Entity
-@Table(name="SPECIALIST")
+@Table(name = "SPECIALIST")
 @Getter
 @Setter
 public class SpecialistEntity extends BaseEntity {
 
 	@Id
 	@GeneratedValue(strategy = GenerationType.SEQUENCE, generator = "SPECIALIST_SEQ_GEN")
-	@SequenceGenerator(sequenceName = "SPECIALIST_SEQ", name = "SPECIALIST_SEQ_GEN", allocationSize = 100, initialValue = 1)
+	@SequenceGenerator(sequenceName = "SPECIALIST_SEQ", name = "SPECIALIST_SEQ_GEN", allocationSize = 100)
 	private Long id;
-	
-	@OneToOne(optional = false, fetch = FetchType.LAZY, cascade = { CascadeType.PERSIST })
+
+	@OneToOne(optional = false, fetch = FetchType.LAZY, cascade = {CascadeType.PERSIST})
 	private UserEntity user;
-	
+
 	@Convert(converter = SpecializationConverter.class)
 	private Specialization specialization;
 
-	@OneToMany(mappedBy = "specialist", fetch = FetchType.LAZY, orphanRemoval = true, cascade = { CascadeType.PERSIST, CascadeType.REMOVE })
+	@OneToMany(mappedBy = "specialist", fetch = FetchType.LAZY, orphanRemoval = true, cascade = {CascadeType.PERSIST,
+			CascadeType.REMOVE})
 	private List<TreatmentEntity> treatments;
 }

src/main/java/com/capgemini/training/appointmentbooking/dataaccess/entity/TreatmentEntity.java

@@ -9,26 +9,25 @@
 import jakarta.persistence.ManyToOne;
 import jakarta.persistence.SequenceGenerator;
 import jakarta.persistence.Table;
-import jakarta.persistence.Version;
 import lombok.Getter;
 import lombok.Setter;
 
 @Entity
-@Table(name="TREATMENT")
+@Table(name = "TREATMENT")
 @Getter
 @Setter
 public class TreatmentEntity extends BaseEntity {
-	
+
 	@Id
 	@GeneratedValue(strategy = GenerationType.SEQUENCE, generator = "TREATMENT_SEQ_GEN")
-	@SequenceGenerator(sequenceName = "TREATMENT_SEQ", name = "TREATMENT_SEQ_GEN", allocationSize = 100, initialValue = 1)
+	@SequenceGenerator(sequenceName = "TREATMENT_SEQ", name = "TREATMENT_SEQ_GEN", allocationSize = 100)
 	private Long id;
-	
+
 	private String name;
-	
+
 	private String description;
-	
-	@Column(name="DURATION_MINUTES")
+
+	@Column(name = "DURATION_MINUTES")
 	private int durationMinutes;
 
 	@ManyToOne(fetch = FetchType.LAZY)

src/main/java/com/capgemini/training/appointmentbooking/dataaccess/entity/UserEntity.java

@@ -7,30 +7,29 @@
 import jakarta.persistence.Id;
 import jakarta.persistence.SequenceGenerator;
 import jakarta.persistence.Table;
-import jakarta.persistence.Version;
 import lombok.Getter;
 import lombok.Setter;
 
 @Entity
-@Table(name="USER_TABLE")
+@Table(name = "USER_TABLE")
 @Getter
 @Setter
 public class UserEntity extends BaseEntity {
-	
+
 	@Id
 	@GeneratedValue(strategy = GenerationType.SEQUENCE, generator = "USER_SEQ_GEN")
-	@SequenceGenerator(sequenceName = "USER_SEQ", name = "USER_SEQ_GEN", allocationSize = 100, initialValue = 1)
+	@SequenceGenerator(sequenceName = "USER_SEQ", name = "USER_SEQ_GEN", allocationSize = 100)
 	private Long id;
-	
+
 	private String email;
-	
-	@Column(name="PASSWORD_HASH")
+
+	@Column(name = "PASSWORD_HASH")
 	private String passwordHash;
-	
-	@Column(name="FIRST_NAME")
+
+	@Column(name = "FIRST_NAME")
 	private String firstname;
-	
-	@Column(name="LAST_NAME")
+
+	@Column(name = "LAST_NAME")
 	private String lastname;
 
 }