Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting a thumbnail doesn't delete alternative resolutions of that thumbnail #660

Open
solarissmoke opened this issue Dec 8, 2020 · 0 comments

Comments

@solarissmoke
Copy link

solarissmoke commented Dec 8, 2020

Calling delete_thumbnails() on a KVStore entry only deletes the default thumbnail on disk - any thumbnails that were generated in alternative resolutions are not deleted.

This feels inconsistent with what someone would expect that method to do - if I ask it to delete all thumbnails, I would expect this to include all alternative resolutions as well.

I think a reasonable default behaviour would be to check THUMBNAIL_ALTERNATIVE_RESOLUTIONS and delete any associated files (if they exist) when the main thumbnail is deleted.

(There is still an edge case where this wouldn't necessarily work if THUMBNAIL_ALTERNATIVE_RESOLUTIONS has changed since the time the thumbnails were generated, but that is probably something that could be documented).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant