Skip to content

Commit c9ef5e9

Browse files
authored
fix(pages): missing assets (#183)
* fix(pages): missing assets This is a PR to try understanding why some assets are not present * fix(ci): correct path * fix(ci): fix path.. * chore(ci): add debug * chore(ci): more and more debug
1 parent bfad43b commit c9ef5e9

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

.github/workflows/pages.yml

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,12 +54,16 @@ jobs:
5454
with:
5555
path: media
5656
key: ${{ runner.os }}-media
57-
- name: Build animation and convert it into HTML slides
57+
- name: Build animations
5858
run: |
5959
poetry run manim example.py ConvertExample BasicExample ThreeDExample
60-
poetry run manim-slides convert ConvertExample docs/source/_static/slides.html -ccontrols=true
61-
poetry run manim-slides convert BasicExample docs/source/_static/basic_example.html -ccontrols=true
62-
poetry run manim-slides convert ThreeDExample docs/source/_static/three_d_example.html -ccontrols=true
60+
- name: Convert animations to HTML slides
61+
run: |
62+
poetry run manim-slides convert -v DEBUG ConvertExample docs/source/_static/slides.html -ccontrols=true
63+
poetry run manim-slides convert -v DEBUG BasicExample docs/source/_static/basic_example.html -ccontrols=true
64+
poetry run manim-slides convert -v DEBUG ThreeDExample docs/source/_static/three_d_example.html -ccontrols=true
65+
- name: Show docs/source/_static/ dir content (video only)
66+
run: tree -L 3 docs/source/_static/ -P '*.mp4'
6367
- name: Clear cache
6468
run: |
6569
gh extension install actions/gh-actions-cache
@@ -80,6 +84,8 @@ jobs:
8084
with:
8185
# Upload docs/build/html dir
8286
path: docs/build/html/
87+
- name: Show docs/build/html/_static/ dir content (video only)
88+
run: tree -L 3 docs/build/html/_static/ -P '*.mp4'
8389
- name: Deploy to GitHub Pages
8490
id: deployment
8591
if: github.event_name != 'pull_request'

manim_slides/convert.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -349,6 +349,8 @@ def convert_to(self, dest: Path) -> None:
349349
)
350350
full_assets_dir = dirname / assets_dir
351351

352+
logger.debug(f"Assets will be saved to: {full_assets_dir}")
353+
352354
os.makedirs(full_assets_dir, exist_ok=True)
353355

354356
for presentation_config in self.presentation_configs:

0 commit comments

Comments
 (0)