Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some enemy names overflow encounter textbox #115

Closed
leo60228 opened this issue Jun 23, 2020 · 6 comments · Fixed by #158
Closed

Some enemy names overflow encounter textbox #115

leo60228 opened this issue Jun 23, 2020 · 6 comments · Fixed by #158

Comments

@leo60228
Copy link

One example is the Ramblin' Evil Mushroom.

@leo60228 leo60228 changed the title Some enemy names overflow textbox Some enemy names overflow encounter textbox Jun 23, 2020
@jeffman
Copy link
Owner

jeffman commented Jun 23, 2020

This one's a real problem and isn't something I anticipated when deciding not to do automatic line breaks. We might have to implement that. Does anyone know how Earthbound handles it?

@PhoenixBound
Copy link
Contributor

PhoenixBound commented Jun 25, 2020

This should still be possible to handle with manual line breaks, I just haven't gotten around to fixing it yet. It's not the enemy names all by themselves that overflow, but them plus the text that leads up to them ("You engage the <enemy name>" and such).

It looks like EarthBound only ever attempts to linebreak at these points (will edit once I get a chance to test more thoroughly):

  • Before an enemy name (this one may not be explicitly handled since the enemy name has a space before it)
  • In between "the " and the enemy name
  • After the enemy name

The result looks like:

- You encounter the
  Ramblin' Evil Mushroom.

@leo60228
Copy link
Author

I also noticed this happening with "Insane Cultist and its cohort," which might be harder to fix.

@PhoenixBound
Copy link
Contributor

The cohorts part is handled in scripting rather than in code so we can just manually use a linebreak if we need to.

And... I should write this down somewhere before I forget. I don't think we've fixed it yet so that all the enemies have the correct intro text? EarthBound changed a few of those, like "The Starman Junior trapped you!" instead of whatever it is in Mother 2. A few overflows may be related to that.

@leo60228
Copy link
Author

The Mother 3 fan translation had the same problem, and ended up using automatic line breaks for battle text only: https://legendsoflocalization.com/mother-3/chapter1-1/#battle-square

This seems a bit heavy-handed, but it'd definitely fix the problem (and some other quirks of battle text)...

@Lorenzooone
Copy link
Collaborator

Current results of testing the encounter text with the updated entries...
test.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants