Clean up and clarification

Author: bitwiseman

src/main/java/org/jenkinsci/plugins/workflow/graph/StandardGraphLookupView.java

@@ -17,7 +17,7 @@
 
 /**
  * Provides overall insight into the structure of a flow graph... but with limited visibility so we can change implementation.
- * Designed to work entirely on the basis of the {@link FlowNode#id} rather than the {@link FlowNode}s themselves.
+ * Designed to work entirely on the basis of the {@link FlowNode#getId()} rather than the {@link FlowNode}s themselves.
  */
 @SuppressFBWarnings(value = "ES_COMPARING_STRINGS_WITH_EQ", justification = "Can can use instance identity when comparing to a final constant")
 @Restricted(NoExternalUse.class)
@@ -40,10 +40,11 @@ public void clearCache() {
     @Override
     public void onNewHead(@Nonnull FlowNode newHead) {
         if (newHead instanceof BlockEndNode) {
-            blockStartToEnd.put(((BlockEndNode)newHead).getStartNode().getId(), newHead.getId());
-            String overallEnclosing = nearestEnclosingBlock.get(((BlockEndNode) newHead).getStartNode().getId());
-            if (overallEnclosing != null) {
-                nearestEnclosingBlock.put(newHead.getId(), overallEnclosing);
+            String startNodeId = ((BlockEndNode)newHead).getStartNode().getId();
+            blockStartToEnd.put(startNodeId, newHead.getId());
+            String enclosingId = nearestEnclosingBlock.get(startNodeId);
+            if (enclosingId != null) {
+                nearestEnclosingBlock.put(newHead.getId(), enclosingId);
             }
         } else {
             if (newHead instanceof BlockStartNode) {
@@ -168,11 +169,9 @@ public BlockEndNode getEndNode(@Nonnull final BlockStartNode startNode) {
                 throw new RuntimeException(ioe);
             }
         } else {
-            BlockEndNode node = bruteForceScanForEnd(startNode);
-            if (node != null) {
-                blockStartToEnd.put(startNode.getId(), node.getId());
-            }
-            return node;
+            // returns the end node or null
+            // if this returns end node, it also adds start and end to blockStartToEnd
+            return bruteForceScanForEnd(startNode);
         }
     }
 
@@ -192,12 +191,8 @@ public BlockStartNode findEnclosingBlockStart(@Nonnull FlowNode node) {
             }
         }
 
-        BlockStartNode enclosing = bruteForceScanForEnclosingBlock(node);
-        if (enclosing != null) {
-            nearestEnclosingBlock.put(node.getId(), enclosing.getId());
-            return enclosing;
-        }
-        return null;
+        // when scan completes, enclosing is in the cache if it exists
+        return bruteForceScanForEnclosingBlock(node);
     }
 
     @Override