Skip to content

Commit b6c9d14

Browse files
authored
Merge pull request #4 from lfolco/master
update docs, remove setup_version from module.xml
2 parents 3892303 + 01c96c3 commit b6c9d14

File tree

7 files changed

+43
-11
lines changed

7 files changed

+43
-11
lines changed

package.json

+5-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
"snippets": [
2525
{
2626
"language": "xml",
27-
"path": "./snippets/layout/arguement.json"
27+
"path": "./snippets/layout/argument.json"
2828
},
2929
{
3030
"language": "xml",
@@ -66,6 +66,10 @@
6666
"language": "php",
6767
"path": "./snippets/module/registration.json"
6868
},
69+
{
70+
"language": "json",
71+
"path": "./snippets/module/composer.json"
72+
},
6973
{
7074
"language": "xml",
7175
"path": "./snippets/events.json"

snippets/di.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,6 @@
5757
"\t$0",
5858
"</virtualType>"
5959
],
60-
"description": "Magento 2 DI type"
60+
"description": "Magento 2 DI virtual type"
6161
}
6262
}
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
11
{
2-
"Arguements": {
2+
"Arguments": {
33
"prefix": "m2.layout.args",
44
"body": [
55
"<arguments>",
66
"\t$0",
77
"</arguments>"
88
],
9-
"description": "Includes a certain layout file"
9+
"description": "Add arguments"
1010
},
1111

12-
"Arguement": {
12+
"Argument": {
1313
"prefix": "m2.layout.arg",
1414
"body": [
1515
"<argument name=\"${1:name}\" xsi:type=\"${2|array,boolean,number,null,object,string|}\">$3</argument>$0"
1616
],
17-
"description": "Includes a certain layout file"
17+
"description": "Add an argument"
1818
}
1919
}

snippets/module/composer.json

+28
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
{
2+
"Composer": {
3+
"prefix": "m2.module.composer",
4+
"body": [
5+
"{",
6+
"\t\"name\": \"${1:vendor}\/module-${2:module}\",",
7+
"\t\"description\": \"N\/A\",",
8+
"\t\"require\": {",
9+
"\t\t\"magento\/framework\": \"*\"",
10+
"\t},",
11+
"\t\"type\": \"magento2-module\",",
12+
"\t\"version\": \"0.1.0\",",
13+
"\t\"license\": [",
14+
"\t\t\"OSL-3.0\"",
15+
"\t],",
16+
"\t\"autoload\": {",
17+
"\t\t\"files\": [",
18+
"\t\t\t\"registration.php\"",
19+
"\t\t],",
20+
"\t\t\"psr-4\": {",
21+
"\t\t\t\"${3:Vendor}\\\\\\\\${4:Module}\\\\\\\": \"\"",
22+
"\t\t}",
23+
"\t}",
24+
"}"
25+
],
26+
"description": "Magento 2 composer.json"
27+
}
28+
}

snippets/module/module.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
"<?xml version=\"1.0\"?>",
66
"<config xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" ",
77
"\t\txsi:noNamespaceSchemaLocation=\"urn:magento:framework:ObjectManager/etc/module.xsd\">",
8-
"\t<module name=\"${1:Vendor_Module}\" setup_version=\"0.1.0\" />",
8+
"\t<module name=\"${1:Vendor_Module}\" />",
99
"</config>"
1010
],
11-
"description": "Magento 2 DI scaffold"
11+
"description": "Magento 2 module.xml"
1212
}
1313
}

snippets/module/registration.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,6 @@
88
"\t__DIR__",
99
");"
1010
],
11-
"description": "Magento 2 registration file"
11+
"description": "Magento 2 registration.php"
1212
}
1313
}

snippets/routes.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"\t$0",
1818
"</router>"
1919
],
20-
"description": "Magento 2 event"
20+
"description": "Magento 2 router"
2121
},
2222
"Route": {
2323
"prefix": "m2.routes.route",
@@ -26,6 +26,6 @@
2626
"\t<module name=\"${3:Vendor_Module}\" />",
2727
"</route>"
2828
],
29-
"description": "Magento 2 event observer"
29+
"description": "Magento 2 route"
3030
}
3131
}

0 commit comments

Comments
 (0)