Testing Async Validators

[d1b1]

Hi, Great blog post and sample code. I am finding that when I stub a Schema Find and try to get the following I never get a response. I looks like the validator starts, but the find in the call does not resolve.

    it('should be invalid if emailkey is not unique', sinon.test(function() {
        var atpl = { emailKey: 'one', name: 'one' };
        this.stub(Template, 'find').yields(null, atpl );

        var m = new Template({ emailKey: 'one', name: ''});

        m.validate(function(err) {
            expect(err.errors.name).to.not.exist;
            done();
        });
    }));

schema.path('emailKey').validate(function (emailKey, fn) {

    // We allow empty phone numbers.
    if (!emailKey) return fn(true);

    // Check only when it is a new user or when phone_number field is modified
    if (this.isNew || this.isModified('emailKey')) {
        var Template = mongoose.model('Template');

        Template.find({ emailKey: emailKey }).exec(function (err, results) {
            fn(!err && results.length === 0);
        });
    } else fn(true);

}, 'Email Key already exists');

[jhartikainen]

One issue which I can see with that test is you're calling done in the validate callback, but you're not passing done as a parameter.

it('should be invalid if emailkey is not unique', sinon.test(function() {

This should be

it('should be invalid if emailkey is not unique', sinon.test(function(done) {

Note the done parameter in the function.

Since the parameter is missing, Mocha assumes this test is synchronous, so the error won't get reported correctly.