Skip to content

Add typing, remove deprecated RelatedLinkColumn #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Add typing, remove deprecated RelatedLinkColumn #974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6089eeb
some typing
jieter Nov 6, 2024
c32d6cb
more
jieter Nov 6, 2024
fdc4dcd
More typing, remove RelatedLinkColumn
jieter Nov 6, 2024
cda13e2
more
jieter Nov 6, 2024
7b0254d
Paginator typing
jieter Nov 6, 2024
88f7317
Use a python 3.9-friendly union type syntax
jieter Dec 21, 2024
e7ef9c6
More typing
jieter Dec 21, 2024
3dbd165
More typing
jieter Dec 21, 2024
eee0524
Even more typing and removing iter methods on BoundColumns
jieter Dec 21, 2024
0f7e5be
Export typing
jieter Dec 21, 2024
7d3f81a
Down to 'Found 51 errors in 12 files (checked 27 source files)'
jieter Dec 21, 2024
c370e24
Current state: Found 20 errors in 10 files (checked 27 source files)
jieter Dec 21, 2024
ffed229
Some more typing
jieter Dec 22, 2024
555071a
Add typing for cell arguments
jieter Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,8 @@ repos:
- id: pyupgrade
args: [--py39-plus]

- repo: https://github.com/pre-commit/mirrors-mypy
rev: v1.14.0
hooks:
- id: mypy
args: ["django_tables2/__init__.py"]
2 changes: 0 additions & 2 deletions django_tables2/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
JSONColumn,
LinkColumn,
ManyToManyColumn,
RelatedLinkColumn,
TemplateColumn,
TimeColumn,
URLColumn,
Expand All @@ -35,7 +34,6 @@
"JSONColumn",
"LinkColumn",
"ManyToManyColumn",
"RelatedLinkColumn",
"TemplateColumn",
"TimeColumn",
"URLColumn",
Expand Down
3 changes: 1 addition & 2 deletions django_tables2/columns/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from .emailcolumn import EmailColumn
from .filecolumn import FileColumn
from .jsoncolumn import JSONColumn
from .linkcolumn import LinkColumn, RelatedLinkColumn
from .linkcolumn import LinkColumn
from .manytomanycolumn import ManyToManyColumn
from .templatecolumn import TemplateColumn
from .timecolumn import TimeColumn
Expand All @@ -26,7 +26,6 @@
"JSONColumn",
"LinkColumn",
"ManyToManyColumn",
"RelatedLinkColumn",
"TemplateColumn",
"URLColumn",
"TimeColumn",
Expand Down
Loading
Loading