Add silentpayments_test_outputs

Author: jlest01

examples/silentpayments.c

@@ -114,6 +114,7 @@ int main(void) {
     enum { N_TX_INPUTS = 2, N_TX_OUTPUTS = 3 };
 
     secp256k1_xonly_pubkey out_pubkeys[N_TX_OUTPUTS];
+    secp256k1_xonly_pubkey *out_pubkeys_ptrs[N_TX_OUTPUTS];
 
     unsigned char randomize[32];
     unsigned char xonly_print[32];
@@ -222,11 +223,15 @@ int main(void) {
             generated_output_ptrs[i] = &generated_outputs[i];
         }
 
+        for (i = 0; i < N_TX_OUTPUTS; i++) {
+            out_pubkeys_ptrs[i] = &out_pubkeys[i];
+        }
+
         ret = secp256k1_silentpayments_test_outputs(
             ctx, 
             recipients, 
             N_TX_OUTPUTS, 
-            out_pubkeys
+            out_pubkeys_ptrs
         );
         assert(ret);
 

include/secp256k1_silentpayments.h

@@ -111,7 +111,7 @@ SECP256K1_API SECP256K1_WARN_UNUSED_RESULT int secp256k1_silentpayments_test_out
     const secp256k1_context *ctx,
     const secp256k1_silentpayments_recipient *recipients,
     size_t n_recipients,
-    secp256k1_xonly_pubkey *generated_outputs
+    secp256k1_xonly_pubkey **generated_outputs
 ) SECP256K1_ARG_NONNULL(1) SECP256K1_ARG_NONNULL(2);
 
 /** Create Silent Payment label tweak and label.

src/modules/silentpayments/main_impl.h

@@ -152,7 +152,7 @@ int secp256k1_silentpayments_test_outputs(
     const secp256k1_context *ctx,
     const secp256k1_silentpayments_recipient *recipients,
     size_t n_recipients,
-    secp256k1_xonly_pubkey *generated_outputs
+    secp256k1_xonly_pubkey **generated_outputs
 ) {
     size_t i;
     int ret = 1;
@@ -167,7 +167,8 @@ int secp256k1_silentpayments_test_outputs(
         if (!ret) {
             return 0;
         }
-        generated_outputs[i] = new_xonly_pubkey;
+        /* generated_outputs[i] = new_xonly_pubkey; */
+        (*generated_outputs)[i] = new_xonly_pubkey;
     }
 
     return ret;