Updated geckodriver version, selenium-webdriver (#74)

* Updated geckodriver version, selenium-webdriver and firefox version for shippable
For geckodriver driver.quit is redundant after driver.close in single window

* Fixing typo

* Adding firefox switch on driver.quit()

Author: mivtachyahu

package.json

@@ -51,11 +51,11 @@
     "electron-prebuilt": "^1.4.13",
     "eyes.selenium": "0.0.72",
     "fs-plus": "2.9.1",
-    "geckodriver": "1.1.2",
+    "geckodriver": "^1.12.2",
     "merge": "1.2.0",
     "phantomjs-prebuilt": "2.1.12",
     "require-dir": "0.3.2",
-    "selenium-webdriver": "3.0.0"
+    "selenium-webdriver": "3.5.0"
   },
   "devDependencies": {
     "eslint": "^3.19.0",

runtime/world.js

@@ -219,16 +219,16 @@ module.exports = function () {
 
     // executed after each scenario (always closes the browser to ensure fresh tests)
     this.After(function (scenario) {
-
         if (scenario.isFailed() && !global.noScreenshot) {
-
             // add a screenshot to the error report
             return driver.takeScreenshot().then(function (screenShot) {
 
                 scenario.attach(new Buffer(screenShot, 'base64'), 'image/png');
-
+                // firefox quits on driver.close on the last window
                 return driver.close().then(function () {
-                    return driver.quit();
+                    if (browserName !== 'firefox'){
+                        return driver.quit();
+                    }
                 })
                 .then(function() {
 
@@ -241,9 +241,11 @@ module.exports = function () {
                 });
             });
         }
-
+        // firefox quits on driver.close on the last window
         return driver.close().then(function () {
-            return driver.quit();
+            if (browserName !== 'firefox'){
+                return driver.quit();
+            }
         })
     });
 };

shippable.yml

@@ -4,7 +4,7 @@ node_js:
   - 6.9.0
 
 addons:
-    firefox: "49.0"
+    firefox: "57.0"
 
 env:
   global: