Skip to content

Crash when hostname is not found with DNS. #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patlefort opened this issue Sep 21, 2022 · 5 comments
Open

Crash when hostname is not found with DNS. #24

patlefort opened this issue Sep 21, 2022 · 5 comments

Comments

@patlefort
Copy link

}
  hostname: 'asmjit'
  syscall: 'getaddrinfo',
  code: 'ENOTFOUND',
  errno: -3008,
    at processTicksAndRejections (node:internal/process/task_queues:83:21) {
    at emitErrorCloseNT (node:internal/streams/destroy:122:3)
    at emitErrorNT (node:internal/streams/destroy:157:8)
    at TLSSocket.emit (node:events:520:28)
    at TLSSocket.socketErrorListener (node:_http_client:442:9)
Emitted 'error' event on ClientRequest instance at:
    at GetAddrInfoReqWrap.onlookup [as oncomplete] (node:dns:71:26)
Error: getaddrinfo ENOTFOUND asmjit
      ^
      throw er; // Unhandled 'error' event

I'm not sure if there is supposed to be something before that }, it's all I have in my log.

@jonasmalacofilho
Copy link
Owner

What URL (or, alternatively, git config replacement rule) are you using?

P.S. Full disclosure: I haven't been able to maintain this, and it's unlikely I'll be able to fix any issues we end up finding here. But maybe it's a usage/config error, or a bug to report in node.

@patlefort
Copy link
Author

The URL was an invalid one that happened by mistake, however it shouldn't cause it to crash. The URL was https://github.com/../asmjit/asmjit.git, due to some weirdness in some AUR package. It got interpreted as GET /asmjit/asmjit.git/info/refs?service=git-upload-pack.

My .gitconfig has

[url "http://pat-server.patdomain.org:52943/"]
        insteadOf = https://

@jonasmalacofilho
Copy link
Owner

And what version or specific commit of git-cache-http-version are you running?

@patlefort
Copy link
Author

The latest commit from this repo.

@jonasmalacofilho
Copy link
Owner

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants