Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSPM support #234

Closed
MadMub opened this issue Nov 4, 2015 · 5 comments
Closed

JSPM support #234

MadMub opened this issue Nov 4, 2015 · 5 comments

Comments

@MadMub
Copy link

MadMub commented Nov 4, 2015

Currently using JSPM/Systemjs for development and module loading. Should support jsoneditor right out of the box (personally I have used it for brace already), however it errors on install of jsonlint because unfortunately jspm does not support commit versions as dependencies.

Basically just wondering if I can use jsoneditor against the lastest release of jsonlint? Or could you make a semver release of your fork of jsonlint?

@josdejong
Copy link
Owner

There is a bug in the jsonlint library: zaach/jsonlint#57

Unfortunately the jsonlint library isn't maintained at the moment (See zaach/jsonlint#56). Therefore I cloned the project, fixed the bug, and point to this fixed version on github.

@MadMub
Copy link
Author

MadMub commented Nov 5, 2015

I understand. The only way to get jspm to install your version of the repo then would be to make a versioned release.

Even if I specify jspm to install from your account, it will grab version 1.6. Obviously the underlying issue is jspm not supporting specific commit versions. For the sake of testing out what I'm personally doing I can just fork your repo and create a versioned tag/branch.

@josdejong
Copy link
Owner

Maybe I should just copy the source code of jsonlint and put it in an assets folder in the jsoneditor project (its stale anyway). I don't like the current link to a git project either.

@MadMub
Copy link
Author

MadMub commented Nov 5, 2015

Sounds good to me, i got a reply from the jspm dev and there are no plans to support commit versions. It's worth mentioning jsoneditor works 100% when importing the dist/ version from the repo. The only issue there is if developers like myself are also already using brace throughout the project then it is loaded twice in memory.

@josdejong
Copy link
Owner

I've fixed this: moved the jsonlint file into an assets folder in the develop branch of this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants