Skip to content

Conversation

@joshuanianji
Copy link
Owner

Closes #68

@joshuanianji joshuanianji requested a review from Copilot March 27, 2025 17:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces updated documentation for the CLI while deprecating the old EdgeDB CLI in favor of the new Gel CLI.

  • Adds a comprehensive NOTES.md for the Gel CLI clarifying usage and configuration.
  • Updates the EdgeDB CLI NOTES.md with deprecation notes, directing users to the Gel CLI repository.

Reviewed Changes

Copilot reviewed 2 out of 6 changed files in this pull request and generated no comments.

File Description
src/gel-cli/NOTES.md Introduces updated documentation for the Gel CLI usage and volume mounts.
src/edgedb-cli/NOTES.md Adds deprecation notes and instructions to redirect users to the Gel CLI.
Files not reviewed (4)
  • src/edgedb-cli/devcontainer-feature.json: Language not supported
  • src/gel-cli/devcontainer-feature.json: Language not supported
  • src/gel-cli/install.sh: Language not supported
  • src/gel-cli/oncreate.sh: Language not supported
Comments suppressed due to low confidence (1)

src/edgedb-cli/NOTES.md:7

  • Consider updating this usage note to reflect the deprecation by replacing 'EdgeDB' and 'edgedb ui' with 'Gel' and 'gel ui' to maintain consistency with the deprecation notice.
**The EdgeDB instance should not be in the same container as the CLI.** My experience doing so makes the `edgedb ui` command start failing once you restart the container. I recommend the following options:

@joshuanianji joshuanianji merged commit bf55a46 into main Mar 28, 2025
@joshuanianji joshuanianji deleted the gel-cli branch March 28, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename edgedb-cli to gel-cli

2 participants