From d3f9920e0f6298fd09f44ddb6d9fcd782a9305c5 Mon Sep 17 00:00:00 2001 From: Joshua Ji Date: Sat, 29 Mar 2025 03:47:36 +0000 Subject: [PATCH 1/4] skip deprecated files --- .github/workflows/test.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 428b5fc..343855f 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -30,6 +30,16 @@ jobs: script: | import os for folder in os.listdir('src'): + config = os.path.join('src', folder, 'devcontainer-feature.json') + if not os.path.isfile(config): + continue + + with open(config, 'r') as f: + data = f.read() + if data.get('deprecated') is True: + print(f"Skipping deprecated feature: {folder}") + continue + print(f"{folder}:") print(f" - '**/{folder}/**'") print(f" - '.github/workflows/test.yaml'") From 6ce06bc6675eff354d600e255c1d6c2dba9340b1 Mon Sep 17 00:00:00 2001 From: Joshua Ji Date: Sat, 29 Mar 2025 04:01:10 +0000 Subject: [PATCH 2/4] use json --- .github/workflows/test.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 343855f..cb37b02 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -29,13 +29,15 @@ jobs: with: script: | import os + import json + for folder in os.listdir('src'): config = os.path.join('src', folder, 'devcontainer-feature.json') if not os.path.isfile(config): continue with open(config, 'r') as f: - data = f.read() + data = json.load(f) if data.get('deprecated') is True: print(f"Skipping deprecated feature: {folder}") continue From 1dbfccbee585a3e70c03120798ef22d0a24a7ffa Mon Sep 17 00:00:00 2001 From: Joshua Ji Date: Sat, 29 Mar 2025 04:45:19 +0000 Subject: [PATCH 3/4] fix paths filter printing --- .github/workflows/test.yaml | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index cb37b02..8949bbe 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -30,7 +30,7 @@ jobs: script: | import os import json - + for folder in os.listdir('src'): config = os.path.join('src', folder, 'devcontainer-feature.json') if not os.path.isfile(config): @@ -42,16 +42,18 @@ jobs: print(f"Skipping deprecated feature: {folder}") continue - print(f"{folder}:") - print(f" - '**/{folder}/**'") - print(f" - '.github/workflows/test.yaml'") + with open('.github/tmp-paths-filter.yml', 'a') as f: + f.write(f"{folder}:") + f.write(f" - '**/{folder}/**'\n") + f.write(f" - '.github/workflows/test.yaml'\n") + + - name: Print paths filter + run: cat .github/tmp-paths-filter.yml - - name: Paths Filter - uses: dorny/paths-filter@v3 + - uses: dorny/paths-filter@v3 id: filter with: - filters: | - ${{ steps.generate-changes.outputs.stdout }} + filters: .github/tmp-paths-filter.yml test-autogenerated: needs: detect-changes From 37cdf9180c9a1e8e6653b98ae00db6dea6e05bf2 Mon Sep 17 00:00:00 2001 From: Joshua Ji Date: Sat, 29 Mar 2025 04:50:04 +0000 Subject: [PATCH 4/4] newline --- .github/workflows/test.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 8949bbe..aa6627a 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -43,7 +43,7 @@ jobs: continue with open('.github/tmp-paths-filter.yml', 'a') as f: - f.write(f"{folder}:") + f.write(f"{folder}:\n") f.write(f" - '**/{folder}/**'\n") f.write(f" - '.github/workflows/test.yaml'\n")