chore: slightly better reach types

Author: jquense

package.json

@@ -64,8 +64,8 @@
     ]
   },
   "devDependencies": {
-    "@4c/cli": "^3.0.1",
-    "@4c/rollout": "^3.0.1",
+    "@4c/cli": "^4.0.1",
+    "@4c/rollout": "^4.0.1",
     "@4c/tsconfig": "^0.4.1",
     "@babel/cli": "^7.18.10",
     "@babel/core": "^7.18.10",
@@ -90,9 +90,9 @@
     "eslint-plugin-typescript": "^0.14.0",
     "hookem": "^2.0.1",
     "jest": "^27.5.1",
-    "lint-staged": "^12.5.0",
+    "lint-staged": "^13.0.3",
     "prettier": "^2.7.1",
-    "rollup": "^2.78.0",
+    "rollup": "^2.78.1",
     "rollup-plugin-babel": "^4.4.0",
     "rollup-plugin-dts": "^4.2.2",
     "rollup-plugin-filesize": "^9.1.2",
@@ -101,8 +101,8 @@
     "typescript": "^4.7.4"
   },
   "dependencies": {
-    "property-expr": "^2.0.4",
-    "tiny-case": "^1.0.2",
+    "property-expr": "^2.0.5",
+    "tiny-case": "^1.0.3",
     "toposort": "^2.0.2"
   }
 }

src/object.ts

@@ -29,7 +29,7 @@ export type { AnyObject };
 type MakeKeysOptional<T> = T extends AnyObject ? _<MakePartial<T>> : T;
 
 export type Shape<T extends Maybe<AnyObject>, C = AnyObject> = {
-  [field in keyof T]: ISchema<T[field], C> | Reference;
+  [field in keyof T]-?: ISchema<T[field], C> | Reference;
 };
 
 export type ObjectSchemaSpec = SchemaSpec<any> & {
@@ -212,7 +212,10 @@ export default class ObjectSchema<
         intermediateValue[prop] = value[prop];
       }
 
-      if (intermediateValue[prop] !== value[prop]) {
+      if (
+        exists !== prop in intermediateValue ||
+        intermediateValue[prop] !== value[prop]
+      ) {
         isChanged = true;
       }
     }

src/util/reach.ts

@@ -1,4 +1,6 @@
 import { forEach } from 'property-expr';
+import type Reference from '../Reference';
+import type { ISchema } from '../types';
 
 let trim = (part: string) => part.substr(0, part.length - 1).substr(1);
 
@@ -7,7 +9,11 @@ export function getIn<C = any>(
   path: string,
   value?: any,
   context: C = value,
-) {
+): {
+  schema: ISchema<any> | Reference;
+  parent: any;
+  parentPath: string;
+} {
   let parent: any, lastPart: string, lastPartDebug: string;
 
   // root path: ''

test/types/types.ts

@@ -962,3 +962,14 @@ Conditions: {
     .when('foo', ([foo]) => (foo ? string() : number()))
     .min(1);
 }
+
+TypeAssigning: {
+  // $ExpectError unknown is not assignable to () => any
+  const _schema: ObjectSchema<{
+    mtime?: Date | null | undefined;
+    toJSON: () => any;
+  }> = object({
+    mtime: date().nullable(),
+    toJSON: mixed().required(),
+  });
+}