Skip to content

Commit c7a77f7

Browse files
committed
BREAKING_CHANGE: remove [protected] disposer instance (remove disposer-itil peer dependency)
1 parent 124ada6 commit c7a77f7

8 files changed

+7
-43
lines changed

package.json

-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@
3737
"url": "git://github.com/js2me/mobx-tanstack-query"
3838
},
3939
"peerDependencies": {
40-
"disposer-util": "^1.0.9",
4140
"mobx": "^6.12.4"
4241
},
4342
"dependencies": {

pnpm-lock.yaml

+7-15
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/mobx-inifinite-query.ts

-4
Original file line numberDiff line numberDiff line change
@@ -102,10 +102,6 @@ export class MobxInfiniteQuery<
102102
queryClient.queryFeatures.enableOnDemand ?? false;
103103
}
104104

105-
if (config.disposer) {
106-
config.disposer.add(() => this.dispose());
107-
}
108-
109105
observable.deep(this, '_result');
110106
observable.ref(this, 'isResultRequsted');
111107
action.bound(this, 'setData');

src/mobx-inifinite-query.types.ts

-5
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import {
66
InfiniteData,
77
DefaultedInfiniteQueryObserverOptions,
88
} from '@tanstack/query-core';
9-
import { IDisposer } from 'disposer-util';
109

1110
import { MobxInfiniteQuery } from './mobx-inifinite-query';
1211
import { MobxQueryClient } from './mobx-query-client';
@@ -118,10 +117,6 @@ export interface MobxInfiniteQueryConfig<
118117
onInit?: (
119118
query: MobxInfiniteQuery<TData, TError, TQueryKey, TPageParam>,
120119
) => void;
121-
/**
122-
* @deprecated use `abortSignal` instead
123-
*/
124-
disposer?: IDisposer;
125120
abortSignal?: AbortSignal;
126121
onDone?: (data: InfiniteData<TData, TPageParam>, payload: void) => void;
127122
onError?: (error: TError, payload: void) => void;

src/mobx-mutation.ts

-4
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,6 @@ export class MobxMutation<
4646
this.queryClient = queryClient;
4747
this.result = undefined as any;
4848

49-
if (config.disposer) {
50-
config.disposer.add(() => this.dispose());
51-
}
52-
5349
observable.deep(this, 'result');
5450
action.bound(this, 'updateResult');
5551

src/mobx-mutation.types.ts

-5
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import {
44
MutationObserverOptions,
55
QueryClient,
66
} from '@tanstack/query-core';
7-
import { IDisposer } from 'disposer-util';
87

98
import { MobxMutation } from './mobx-mutation';
109
import { MobxQueryClient } from './mobx-query-client';
@@ -49,10 +48,6 @@ export interface MobxMutationConfig<
4948
>,
5049
MobxMutationFeatures {
5150
queryClient: QueryClient | MobxQueryClient;
52-
/**
53-
* @deprecated use `abortSignal` instead
54-
*/
55-
disposer?: IDisposer;
5651
abortSignal?: AbortSignal;
5752
invalidateQueries?:
5853
| MobxMutationInvalidateQueriesOptions

src/mobx-query.ts

-4
Original file line numberDiff line numberDiff line change
@@ -82,10 +82,6 @@ export class MobxQuery<
8282
queryClient.queryFeatures.enableOnDemand ?? false;
8383
}
8484

85-
if (config.disposer) {
86-
config.disposer.add(() => this.dispose());
87-
}
88-
8985
observable.deep(this, '_result');
9086
observable.ref(this, 'isResultRequsted');
9187
action.bound(this, 'setData');

src/mobx-query.types.ts

-5
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import {
88
QueryObserverOptions,
99
RefetchOptions,
1010
} from '@tanstack/query-core';
11-
import { IDisposer } from 'disposer-util';
1211

1312
import type { MobxQuery } from './mobx-query';
1413
import { MobxQueryClient } from './mobx-query-client';
@@ -103,10 +102,6 @@ export interface MobxQueryConfig<
103102
*/
104103
queryKey?: TQueryKey | (() => TQueryKey);
105104
onInit?: (query: MobxQuery<TData, TError, TQueryKey>) => void;
106-
/**
107-
* @deprecated use `abortSignal` instead
108-
*/
109-
disposer?: IDisposer;
110105
abortSignal?: AbortSignal;
111106
onDone?: (data: TData, payload: void) => void;
112107
onError?: (error: TError, payload: void) => void;

0 commit comments

Comments
 (0)