required properties are not enforced

[donalmurtagh]

In both the camelcase and minimal examples there are 2 fields of the custom type, one of which is optional and the other is required. For example, in the schema of the minimal example, it's the 2nd field that's required

    $scope.schema = {
        type: "object",
        title: "Minimal",
        properties: {
            minimalFormat: {
                type: "string",
                format: "minimal",
                description: "When you edit this, it is in the add-ons input box."
            },
            minimalFormType: {
                type: "string",
                description: "When you edit this, which is required, it is equally in the add-ons input box"
            }
        },
        required: ["minimalFormType"]
    };

However, if we change the form's submission handler to:

    $scope.submitted = function (form) {
        $scope.$broadcast("schemaFormValidate");
        console.log($scope.model);

        // the line below is the only change I made to this function
        console.log('Form is valid:', form.$valid);
    };

We'll see that the form is considered valid even if nothing is entered in the required field

[nicklasb]

Strange. Especially as is not the add-on but ASF that do the validation of the model.

[donalmurtagh]

Do you think I should raise this as an ASF bug?
The only workaround I can think of is to add an explicit required property to the schema (which will be false if omitted), e.g.

    $scope.schema = {
        type: "object",
        title: "Minimal",
        properties: {
            minimalFormat: {
                type: "string",
                format: "minimal",
                description: "When you edit this, it is in the add-ons input box."
            },
            minimalFormType: {
                type: "string",
                description: "When you edit this, which is required, it is equally in the add-ons input box",
                required: true
            }
        }    
    };

Then programatically validate the field in the directive like this:

    return {
      restrict: 'EA',
      require: 'ngModel',
      scope: {
        ngModel: '=',
        form: '='
      },
      link: function (scope, element, attrs, ngModelCtrl) {

        scope.$watch('ngModel', function (newValue, oldValue) {
          if (scope.form.schema.required) {
            ngModelCtrl.$setValidity("myFieldKey", !!newValue);
          }
        });
      }
    };

I don't particularly like this approach, but I can't think of a better one, can you?

[nicklasb]

Aha, now I remember, required at that level means that the property needs
to be in the data, not that it has to be set to anything else than "".
On 19 Jan 2016 17:02, "Dónal Murtagh" notifications@github.com wrote:

So do you think I should open raise this as an ASF bug?
The only workaround I can find for this is adding an explicit required
property to the schema (which will be false if omitted), e.g.

$scope.schema = {
    type: "object",
    title: "Minimal",
    properties: {
        minimalFormat: {
            type: "string",
            format: "minimal",
            description: "When you edit this, it is in the add-ons input box."
        },
        minimalFormType: {
            type: "string",
            description: "When you edit this, which is required, it is equally in the add-ons input box",
            required: true
        }
    }
};

The programatically validating the field in the directive like so

return {
  restrict: 'EA',
  require: 'ngModel',
  link: function (scope, element, attrs, ngModel) {
    scope.$watch('ngModel', function (newValue, oldValue) {
      if (!newValue && scope.form.required) {
        ngModel.$setValidity("myFieldKey", false);
      }
    });
  }
}

I don't particularly like this approach, but I can't think of a better
one, can you?

—
Reply to this email directly or view it on GitHub
#10 (comment)
.

[donalmurtagh]

Aha, now I remember, required at that level means that the property needs to be in the data, not that it has to be set to anything else than "".

Do you mean that if you specify required like this

    $scope.schema = {
        type: "object",
        title: "Minimal",
        properties: {
            minimalFormat: {
                type: "string",
                format: "minimal",
                description: "When you edit this, it is in the add-ons input box."
            },
            minimalFormType: {
                type: "string",
                description: "When you edit this, which is required, it is equally in the add-ons input box"
            }
        },
        required: ["minimalFormType"]
    };

It means that minimalFormType must be in the model, but doesn't have to have any particular value? If so, then it still seems there's a bug. because in the minimal example if we set:

<form name="selectForm" sf-schema="schema" sf-form="form" sf-model="model" ng-submit="submitted(selectForm)"></form>

and the submission handler is defined as

    $scope.submitted = function (form) {
        $scope.$broadcast("schemaFormValidate");
        console.log($scope.model);
        console.log('Form is valid:', form.$valid);
    };

then we get the following output indicating that the form is valid even if the mandatory field is not in the model

Object { minimalFormat="default value"}
Form is valid: true

[nicklasb]

Ok. I'll take another look when I get home.
On 19 Jan 2016 17:44, "Dónal Murtagh" notifications@github.com wrote:

Aha, now I remember, required at that level means that the property needs
to be in the data, not that it has to be set to anything else than "".

Do you mean that if you specify required like this

$scope.schema = {
    type: "object",
    title: "Minimal",
    properties: {
        minimalFormat: {
            type: "string",
            format: "minimal",
            description: "When you edit this, it is in the add-ons input box."
        },
        minimalFormType: {
            type: "string",
            description: "When you edit this, which is required, it is equally in the add-ons input box"
        }
    },
    required: ["minimalFormType"]
};

It means that minimalFormType must be in the model, but doesn't have to
have any particular value? If so, then it still seems there's a bug.
because in the minimal example if we set:

and the submission handler is defined as

$scope.submitted = function (form) {
    $scope.$broadcast("schemaFormValidate");
    console.log($scope.model);
    console.log('Form is valid:', form.$valid);
};

then we get the following output indicating that the form is valid even if
the mandatory field is not in the model

Object { minimalFormat="default value"}
Form is valid: true

—
Reply to this email directly or view it on GitHub
#10 (comment)
.

[nicklasb]

Meanwhile, try it in the asf example.
On 19 Jan 2016 17:54, "Nicklas Börjesson" nicklasb@gmail.com wrote:

Ok. I'll take another look when I get home.
On 19 Jan 2016 17:44, "Dónal Murtagh" notifications@github.com wrote:

Aha, now I remember, required at that level means that the property needs
to be in the data, not that it has to be set to anything else than "".

Do you mean that if you specify required like this

$scope.schema = {
    type: "object",
    title: "Minimal",
    properties: {
        minimalFormat: {
            type: "string",
            format: "minimal",
            description: "When you edit this, it is in the add-ons input box."
        },
        minimalFormType: {
            type: "string",
            description: "When you edit this, which is required, it is equally in the add-ons input box"
        }
    },
    required: ["minimalFormType"]
};

It means that minimalFormType must be in the model, but doesn't have to
have any particular value? If so, then it still seems there's a bug.
because in the minimal example if we set:

and the submission handler is defined as

$scope.submitted = function (form) {
    $scope.$broadcast("schemaFormValidate");
    console.log($scope.model);
    console.log('Form is valid:', form.$valid);
};

then we get the following output indicating that the form is valid even
if the mandatory field is not in the model

Object { minimalFormat="default value"}
Form is valid: true

—
Reply to this email directly or view it on GitHub
#10 (comment)
.

[donalmurtagh]

Meanwhile, try it in the asf example.

What exactly do you mean by "it" - the workaround I proposed?

[nicklasb]

I was just proposing that to be certain that the problem is in the add-on example.
Anyway, I just tried, and it seems that validation work as it would be expected there, and that there is some kind of problem with the example. I'll get back to you.

[donalmurtagh]

Thanks in advance for your help

[nicklasb]

Well. There is some kind of problem with the validation.
If I don't use the add-on, it works, and if add it, it stops working.
I have compared to for example datepicker, and it seems to be no important difference.
Very strange.