Enable Job Definitions to be edited

[ellisonbg]

Problem

In our initial work on adding job scheduling, we probably won't get to making Job Definitions editable. This issue is to track that follow on work.

Proposed Solution

The list and detail view for a Job Definition should have an Edit action that allows the user to reconfigure elements of the scheduled job. See the REST API for which fields are editable:

#45

[andrii-i]

@ellisonbg Some questions / consideration raised based on the discussion with @3coins and @dlqqq:

1. Editable fields. Which Job Definition fields should be editable?

• From API/backend perspective, any Job Definition field can be edited
• Clarified ✅: as a 1st step only Scheduling-related fields Schedule and Timezone are expected to be editable

2. (✅ proceed with this option 3) User flow needs validation/approval. Proposed user flow:

• Option 1 (I think works best if all/majority of fields can be edited): add Edit button to Job Definition Detail button bar. When it is clicked, editable text fields become editable and button changes to Save. When Save is clicked, text fields become uneditable, changes to Job Definition are sent to the server and updated Job Definition Detail is shown
• Option 2: if only 2 fields out of 9 can be edited, add small Edit / Save buttons/links above Schedule and Timezone fields.
• Option 3 (as described in Repurpose create form as "edit" form for job definitions #172 ): create new element, Job Form that would be used by both Detail View and Create Job. Job Form would have 2 modes: view and edit where view mode would be used in Detail View and edit view would be used in Create Job and when you click ‘Edit’ in Detail View . This option requires biggest refactoring but it would optimize the structure and control flow of application, reduce code duplication
• Add Edit icon to Job Definition List icon bar. On click, Job Definition Detail in edit mode (with editable text fields described above opens up

(Issue to consider: we need to effectively differentiate editable vs read-only fields. Currently all fields in Detail View are read-only meaning you can't edit them but they look (in terms of styling) and behave (in terms of interactions) as usual input fields; see #173 for proposed solution)

3. (Done ✅) Showing Advanced options in Job Definition Detail: currently Advanced Options are only shown at the bottom of Job Detail page. At the same time, as mentioned by @3coins, fields provided to Advanced Options might be / are meaningful for Job Definition Detail page too, especially if Job Definition can be edited as user might need to edit Advanced Options for Job Definition too. Created issue Expose Advanced Options in Job Definition Detail #160 to track this and facilitate discussion around it
4. The advanced options inputs will / might still be editable in the detail view. Editable/read-only state of Jobs Definition should also extend to edit-ability / read-only state of AdvancedOptions displayed on the page (as mentioned by @dlqqq in Expose Advanced Options in Job Definition Detail  #164). Created Editable/read-only state of Advanced Options in Job Definition Detail #165 to track this

[dlqqq]

From 10/20/2022 standup: Start with schedule and timezone being editable, add other fields afterwards upon receiving more user feedback.