Skip to content

Commit e0b0018

Browse files
Hind-MHind-M
committed
Remove redundant apply_patch_to_registered_properties
1 parent 89f5fc4 commit e0b0018

34 files changed

Lines changed: 1 addition & 49 deletions

‎docs/source/custom.rst‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ holding values of that type.
169169

170170
**Deserialization**
171171

172-
The deserialization of properties from the patch is handled by calling `apply_patch_to_registered_properties` on the widget instance.
172+
The deserialization of properties from the patch is handled by calling `apply_patch_to_registered_properties` on the base widget instance.
173173

174174
This member function is responsible for deserializing the patch by iterating over the registered properties.
175175
These properties self-register upon construction in the class.

‎include/xwidgets/xaudio.hpp‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ namespace xw
6969
inline void xaudio<D>::apply_patch(const nl::json& patch, const xeus::buffer_sequence& buffers)
7070
{
7171
base_type::apply_patch(patch, buffers);
72-
this->apply_patch_to_registered_properties(patch, buffers);
7372
}
7473

7574
template <class D>

‎include/xwidgets/xboolean.hpp‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ namespace xw
6464
inline void xboolean<D>::apply_patch(const nl::json& patch, const xeus::buffer_sequence& buffers)
6565
{
6666
base_type::apply_patch(patch, buffers);
67-
this->apply_patch_to_registered_properties(patch, buffers);
6867
}
6968

7069
template <class D>

‎include/xwidgets/xbox.hpp‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,6 @@ namespace xw
128128
inline void xbox<D>::apply_patch(const nl::json& patch, const xeus::buffer_sequence& buffers)
129129
{
130130
base_type::apply_patch(patch, buffers);
131-
this->apply_patch_to_registered_properties(patch, buffers);
132131
}
133132

134133
template <class D>

‎include/xwidgets/xbutton.hpp‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,6 @@ namespace xw
132132
inline void xbutton_style<D>::apply_patch(const nl::json& patch, const xeus::buffer_sequence& buffers)
133133
{
134134
base_type::apply_patch(patch, buffers);
135-
this->apply_patch_to_registered_properties(patch, buffers);
136135
}
137136

138137
template <class D>
@@ -171,7 +170,6 @@ namespace xw
171170
inline void xbutton<D>::apply_patch(const nl::json& patch, const xeus::buffer_sequence& buffers)
172171
{
173172
base_type::apply_patch(patch, buffers);
174-
this->apply_patch_to_registered_properties(patch, buffers);
175173
}
176174

177175
template <class D>

‎include/xwidgets/xcheckbox.hpp‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,6 @@ namespace xw
9696
inline void xcheckbox_style<D>::apply_patch(const nl::json& patch, const xeus::buffer_sequence& buffers)
9797
{
9898
base_type::apply_patch(patch, buffers);
99-
this->apply_patch_to_registered_properties(patch, buffers);
10099
}
101100

102101
template <class D>
@@ -130,7 +129,6 @@ namespace xw
130129
inline void xcheckbox<D>::apply_patch(const nl::json& patch, const xeus::buffer_sequence& buffers)
131130
{
132131
base_type::apply_patch(patch, buffers);
133-
this->apply_patch_to_registered_properties(patch, buffers);
134132
}
135133

136134
template <class D>

‎include/xwidgets/xcolor_picker.hpp‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ namespace xw
6868
inline void xcolor_picker<D>::apply_patch(const nl::json& patch, const xeus::buffer_sequence& buffers)
6969
{
7070
base_type::apply_patch(patch, buffers);
71-
this->apply_patch_to_registered_properties(patch, buffers);
7271
}
7372

7473
template <class D>

‎include/xwidgets/xcontroller.hpp‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,6 @@ namespace xw
139139
inline void xcontroller_button<D>::apply_patch(const nl::json& patch, const xeus::buffer_sequence& buffers)
140140
{
141141
base_type::apply_patch(patch, buffers);
142-
this->apply_patch_to_registered_properties(patch, buffers);
143142
}
144143

145144
template <class D>
@@ -176,7 +175,6 @@ namespace xw
176175
inline void xcontroller_axis<D>::apply_patch(const nl::json& patch, const xeus::buffer_sequence& buffers)
177176
{
178177
base_type::apply_patch(patch, buffers);
179-
this->apply_patch_to_registered_properties(patch, buffers);
180178
}
181179

182180
template <class D>
@@ -219,7 +217,6 @@ namespace xw
219217
inline void xcontroller<D>::apply_patch(const nl::json& patch, const xeus::buffer_sequence& buffers)
220218
{
221219
base_type::apply_patch(patch, buffers);
222-
this->apply_patch_to_registered_properties(patch, buffers);
223220
}
224221

225222
template <class D>

‎include/xwidgets/xhtml.hpp‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ namespace xw
9898
inline void xhtml_style<D>::apply_patch(const nl::json& patch, const xeus::buffer_sequence& buffers)
9999
{
100100
base_type::apply_patch(patch, buffers);
101-
this->apply_patch_to_registered_properties(patch, buffers);
102101
}
103102

104103
template <class D>
@@ -132,7 +131,6 @@ namespace xw
132131
inline void xhtml<D>::apply_patch(const nl::json& patch, const xeus::buffer_sequence& buffers)
133132
{
134133
base_type::apply_patch(patch, buffers);
135-
this->apply_patch_to_registered_properties(patch, buffers);
136134
}
137135

138136
template <class D>

‎include/xwidgets/ximage.hpp‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ namespace xw
6767
inline void ximage<D>::apply_patch(const nl::json& patch, const xeus::buffer_sequence& buffers)
6868
{
6969
base_type::apply_patch(patch, buffers);
70-
this->apply_patch_to_registered_properties(patch, buffers);
7170
}
7271

7372
template <class D>

0 commit comments

Comments
 (0)