Skip to content

Commit 2f01c41

Browse files
authored
Merge pull request #347 from krassowski/eq-in-args
Support traitlets versions < 5.0
2 parents 3fc1575 + de38c4d commit 2f01c41

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

src/main/server.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,14 +71,17 @@ class JupyterServer {
7171
}
7272
this._info.token = randomBytes(24).toString('hex');
7373

74+
// note: traitlets<5.0 require fully specified arguments to
75+
// be followed by equals sign without a space; this can be
76+
// removed once jupyter_server requires traitlets>5.0
7477
this._nbServer = execFile(this._info.environment.path, [
7578
'-m', 'jupyterlab',
7679
'--no-browser',
7780
// do not use any config file
78-
'--JupyterApp.config_file_name', '',
81+
'--JupyterApp.config_file_name=""',
7982
// use our token rather than any pre-configured password
80-
'--ServerApp.password', '',
81-
'--ServerApp.allow_origin', '*'
83+
'--ServerApp.password=""',
84+
'--ServerApp.allow_origin="*"'
8285
], {
8386
cwd: home,
8487
env: {

0 commit comments

Comments
 (0)