From de38c4d0ee795e8770c53bac10f424e1e47f3c0a Mon Sep 17 00:00:00 2001 From: krassowski Date: Wed, 24 Nov 2021 20:25:46 +0000 Subject: [PATCH] Support traitlets versions <5.0 such as >=4.2.1 required by jupyter_server --- src/main/server.ts | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/main/server.ts b/src/main/server.ts index 50e02893..3e1b02eb 100644 --- a/src/main/server.ts +++ b/src/main/server.ts @@ -71,14 +71,17 @@ class JupyterServer { } this._info.token = randomBytes(24).toString('hex'); + // note: traitlets<5.0 require fully specified arguments to + // be followed by equals sign without a space; this can be + // removed once jupyter_server requires traitlets>5.0 this._nbServer = execFile(this._info.environment.path, [ '-m', 'jupyterlab', '--no-browser', // do not use any config file - '--JupyterApp.config_file_name', '', + '--JupyterApp.config_file_name=""', // use our token rather than any pre-configured password - '--ServerApp.password', '', - '--ServerApp.allow_origin', '*' + '--ServerApp.password=""', + '--ServerApp.allow_origin="*"' ], { cwd: home, env: {