Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove playwright browser installation #12

Open
brichet opened this issue Sep 14, 2023 · 4 comments
Open

Remove playwright browser installation #12

brichet opened this issue Sep 14, 2023 · 4 comments
Labels
maintenance

Comments

@brichet
Copy link
Collaborator

brichet commented Sep 14, 2023 •
edited
Loading

Follow #11

Playwright browser are not automatically installed since v1.38.0.

This broke the build test, because jupyterlab/check_browser does not install it too.

This has been fixed in #11, but the fix should be removed as soon as the jupyterlab/check_browser installs the browser.
@jtpio
Copy link
Member

jtpio commented Sep 14, 2023

the fix should be removed as soon as the jupyterlab/check_browser installs the browser.

Should we track or directly fix this upstream in JupyterLab?

@brichet
Copy link
Collaborator Author

brichet commented Sep 14, 2023

No sure to understand your question.
We should fix it, but then wait for a release and a backport to v3.5.

@jtpio
Copy link
Member

jtpio commented Sep 14, 2023

I meant opening an issue in https://github.com/jupyterlab/jupyterlab.

Or directly fix this in https://github.com/jupyterlab/jupyterlab as a PR.

@brichet
Copy link
Collaborator Author

brichet commented Sep 14, 2023

I opened jupyterlab/jupyterlab#15116 and I'm testing a change locally to open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jtpio @brichet