Test

Author: VincentBean

Diff for: src/Actions/DiscoverMagentoProducts.php

@@ -34,15 +34,19 @@ public function discover(int $page, Batch $batch): void
         $hasNextPage = $products->count() == config('magento-products.page_size');
 
         if ($hasNextPage) {
-            /* $batch->add(new DiscoverMagentoProductsJob($page + 1)); */
+            $batch->add(new DiscoverMagentoProductsJob($page + 1));
         }
 
         $skus = $products->pluck('sku');
-        /* $this->skuProcessor->process($skus); */
+        $this->skuProcessor->process($skus);
 
         foreach ($products as $productData) {
             $product = MagentoProduct::query()->firstOrNew(['sku' => $productData['sku']]);
-            $checksum = md5(json_encode($productData));
+
+            /** @var non-empty-string $encoded */
+            $encoded = json_encode($productData);
+
+            $checksum = md5($encoded);
 
             if ($product->checksum !== $checksum) {
                 event(new ProductDataModifiedEvent($product->sku, $product->data, $productData));

Diff for: tests/Actions/DiscoverMagentoProductsTest.php

@@ -143,6 +143,17 @@ public function it_does_not_dispatch_event_when_checksum_has_not_changed(): void
     #[Test]
     public function it_dispatches_next_job(): void
     {
+        Http::fake([
+            'magento/rest/all/V1/products?searchCriteria%5BpageSize%5D=1&searchCriteria%5BcurrentPage%5D=0' => Http::response([
+                'items' => [
+                    ['sku' => '123'],
+                ],
+            ]),
+            'magento/rest/all/V1/products?searchCriteria%5BpageSize%5D=1&searchCriteria%5BcurrentPage%5D=1' => Http::response([
+                'items' => [],
+            ]),
+        ])->preventingStrayRequests();
+        config()->set('magento-products.page_size', 1);
 
         $this->mock(ProcessesMagentoSkus::class, function (MockInterface $mock) {
             $mock->shouldReceive('process')->once();
@@ -168,6 +179,12 @@ public function it_dispatches_next_job(): void
     #[Test]
     public function it_sets_retrieved_false(): void
     {
+        Http::fake([
+            'magento/rest/all/V1/products?searchCriteria%5BpageSize%5D=2&searchCriteria%5BcurrentPage%5D=0' => Http::response([
+                'items' => [],
+            ]),
+        ])->preventingStrayRequests();
+
         MagentoProduct::query()->create([
             'sku' => '123',
             'exists_in_magento' => true,
@@ -198,6 +215,14 @@ public function it_sets_retrieved_false(): void
     #[Test]
     public function it_sets_retrieved_true(): void
     {
+        Http::fake([
+            'magento/rest/all/V1/products?searchCriteria%5BpageSize%5D=2&searchCriteria%5BcurrentPage%5D=0' => Http::response([
+                'items' => [
+                    ['sku' => '123'],
+                ],
+            ]),
+        ])->preventingStrayRequests();
+
         MagentoProduct::query()->create([
             'sku' => '123',
             'exists_in_magento' => true,