Circular dependency after upgrade to 3.9.0

[tcoluke]

I met with problems after upgrade your module to 3.9.0 on one of our projects...

Circular dependency: CyberSource\SecureAcceptance\Plugin\Store\Api\StoreResolverInterfacePlugin depends on JustBetter\Sentry\Plugin\MonologPlugin and vice versa.

Circular dependency: JustBetter\Sentry\Plugin\MonologPlugin depends on CyberSource\SecureAcceptance\Plugin\Store\Api\StoreResolverInterfacePlugin and vice versa.

we use package of "cybersource/global-payment-management": "3.5.8"

on our project so you can check what is going wrong and maybe fix it on your side

problem is on CyberSource\SecureAcceptance\Plugin\Store\Api\StoreResolverInterfacePlugin

code looks like

<?php
/*
 * Copyright © 2020 CyberSource. All rights reserved.
 * See accompanying LICENSE.txt for applicable terms of use and license.
 */
namespace CyberSource\SecureAcceptance\Plugin\Store\Api;

class StoreResolverInterfacePlugin
{
    /**
     * @var \Magento\Framework\App\RequestInterface
     */
    private $request;

    /**
     * @var \CyberSource\SecureAcceptance\Gateway\Config\SaConfigProviderInterface
     */
    private $configProvider;

    /**
     * @var \Magento\Framework\Encryption\EncryptorInterface
     */
    private $encryptor;

    /**
     * @var \CyberSource\SecureAcceptance\Model\SignatureManagementInterface
     */
    private $signatureManagement;

    /**
     * @var \CyberSource\Core\Model\LoggerInterface
     */
    private $logger;

    /**
     * @var \Magento\Store\Api\StoreRepositoryInterface
     */
    private $storeRepository;

    private $requestSubstituted = false;

    public function __construct(
        \Magento\Framework\App\RequestInterface $request,
        \CyberSource\SecureAcceptance\Gateway\Config\SaConfigProviderInterfaceFactory $configProviderFactory,
        \CyberSource\SecureAcceptance\Gateway\Config\ConfigFactory $configFactory,
        \Magento\Framework\Encryption\EncryptorInterface $encryptor,
        \CyberSource\SecureAcceptance\Model\SignatureManagementInterface $signatureManagement,
        \CyberSource\Core\Model\LoggerInterface $logger,
        \Magento\Store\Api\StoreRepositoryInterface $storeRepository
    ) {
        $this->request = $request;
        $this->configProvider = $configProviderFactory->create();
        $this->encryptor = $encryptor;
        $this->signatureManagement = $signatureManagement;
        $this->logger = $logger;
        $this->storeRepository = $storeRepository;
    }

    public function beforeGetCurrentStoreId(\Magento\Store\Api\StoreResolverInterface $subject)
    {
        if ($this->requestSubstituted) {
            return;
        }

        if (!$this->request->isPost()) {
            return;
        }

        if (!$storeId = $this->getSaReqParam(\CyberSource\SecureAcceptance\Helper\RequestDataBuilder::KEY_STORE_ID)) {
            return;
        }

        if (!$this->signatureManagement->validateSignature(
            $this->request->getParams(),
            $this->configProvider->getSecretKey($storeId)
        )) {
            $this->logger->warning(static::class . ': Invalid SA signature for store ' . $storeId);
            return;
        }

        try {
            $store = $this->storeRepository->getActiveStoreById($storeId);
        } catch (\Exception $e) {
            $this->logger->warning(static::class . ': No store with found with ID ' . $storeId);
            return;
        }

        $originalParams = $this->request->getParams();

        $this->request->setParams(
            array_merge(
                $originalParams,
                [
                    \Magento\Store\Api\StoreResolverInterface::PARAM_NAME => $store->getCode(),
                ]
            )
        );

        $this->requestSubstituted = true;
    }

    private function getSaReqParam($value)
    {
        return $this->request->getParam('req_' . $value, null);
    }
}

for now I've locked your module back to 3.8.0 (on this version I haven't this problem)

[indykoning]

Hi, due to the custom code i cannot reproduce the issue. However i have an idea where it could be coming from.
Could you try removing

• magento2-sentry/Plugin/MonologPlugin.php

  Line 25 in 00304ca

  protected Data $sentryHelper,

• and the sentryhelper here:

  magento2-sentry/Plugin/MonologPlugin.php

  Line 50 in 00304ca

  if ($this->deploymentConfig->isAvailable() && $this->sentryHelper->isActive()) {

And seeing if the issue gets resolved