Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for localization #29

Closed
wants to merge 2 commits into from
Closed

Add support for localization #29

wants to merge 2 commits into from

Conversation

claudioandre-br
Copy link
Contributor

Fixes and closes #28


Please, let me know if you need anything else done (I did this only to check how i18n works, I'm affraid I'm not interested in put much effort in it).

image

@jwendell
Copy link
Owner

Thanks for the initial work on this. I think this is not complete, right? I mean it's not working out of the box, is it?

@claudioandre-br
Copy link
Contributor Author

claudioandre-br commented Mar 29, 2017

Yes, it is.

Well, I haven't added the .mo file (and the user has to copy the .mo file to the proper location while installing). But all this is done when you release the extension.

  • if you mean that it doesn't work if I do a local (to my home) installation:
    • are you going to accept a compiled .mo file in github?

@jwendell
Copy link
Owner

Yeah, I'm expecting a fully working PR :)

Perhaps this involves the creation of a Makefile to generate those binaries at build time. Take a look at how other extensions do that.

@claudioandre-br
Copy link
Contributor Author

claudioandre-br commented Mar 30, 2017

I failed to find any other extension that has the .mo file on GitHub. Yes, they use autotools.

@jwendell
Copy link
Owner

https://github.com/jenslody/gnome-shell-extension-openweather is an example.
Just like any other software that uses gettext, you'll likely find only the sources of translations out there (.po files). Binary (.mo) are the result of the building process.

@claudioandre-br
Copy link
Contributor Author

I added the compiled .mo file. But I guess what you want now it to use autotools to build the extension, and later, add the translation. Is that correct?

@jwendell
Copy link
Owner

Yep, that's correct. If using autotools is the way to achieve our goal, i.e., support translations, then go for it. Having .mo files versioned is not an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support i18n
2 participants