Merge branch 'master' of https://github.com/jwillemsen/daikin_onecta

Author: jwillemsen

.github/workflows/tests.yaml

@@ -34,6 +34,7 @@ jobs:
             tests
       - name: Upload coverage reports to Codecov with GitHub Action
         uses: codecov/codecov-action@v4
+        if: always()
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
           slug: jwillemsen/daikin_onecta

custom_components/daikin_onecta/climate.py

@@ -781,23 +781,42 @@ def get_preset_modes(self):
 
     async def async_turn_on(self):
         """Turn device CLIMATE on."""
+        _LOGGER.debug("Device '%s' request to turn on", self._device.name)
         cc = self.climate_control()
-        result = await self._device.set_path(self._device.getId(), self.embedded_id, "onOffMode", "", "on")
-        if result is False:
-            _LOGGER.warning("Device '%s' problem setting onOffMode to on", self._device.name)
+        result = True
+        if cc["onOffMode"]["value"] == "off":
+            result &= await self._device.set_path(self._device.getId(), self.embedded_id, "onOffMode", "", "on")
+            if result is False:
+                _LOGGER.error("Device '%s' problem setting onOffMode to on", self._device.name)
+            else:
+                cc["onOffMode"]["value"] = "on"
+                self._attr_hvac_mode = self.get_hvac_mode()
+                self.async_write_ha_state()
         else:
-            cc["onOffMode"]["value"] = "on"
-            self._attr_hvac_mode = self.get_hvac_mode()
-            self.async_write_ha_state()
+            _LOGGER.debug(
+                "Device '%s' request to turn on ignored because device is already on",
+                self._device.name,
+            )
+
         return result
 
     async def async_turn_off(self):
-        result = await self._device.set_path(self._device.getId(), self.embedded_id, "onOffMode", "", "off")
-        if result is False:
-            _LOGGER.warning("Device '%s' problem setting onOffMode to off", self._device.name)
+        _LOGGER.debug("Device '%s' request to turn off", self._device.name)
+        cc = self.climate_control()
+        result = True
+        if cc["onOffMode"]["value"] == "on":
+            result &= await self._device.set_path(self._device.getId(), self.embedded_id, "onOffMode", "", "off")
+            if result is False:
+                _LOGGER.error("Device '%s' problem setting onOffMode to off", self._device.name)
+            else:
+                cc["onOffMode"]["value"] = "off"
+                self._attr_hvac_mode = self.get_hvac_mode()
+                self.async_write_ha_state()
         else:
-            self._attr_hvac_mode = HVACMode.OFF
-            self.async_write_ha_state()
+            _LOGGER.debug(
+                "Device '%s' request to turn off ignored because device is already off",
+                self._device.name,
+            )
 
         return result