Skip to content

Commit 1f987e1

Browse files
authored
Merge pull request #226 from jwillemsen/jwi-nonsettableoperatoinmode
Only export the hvac modes which can be set or which is current
2 parents 76a8abe + 5140337 commit 1f987e1

File tree

2 files changed

+9
-12
lines changed

2 files changed

+9
-12
lines changed

custom_components/daikin_onecta/climate.py

+9-4
Original file line numberDiff line numberDiff line change
@@ -350,10 +350,15 @@ def get_hvac_modes(self):
350350
modes = [HVACMode.OFF]
351351
operationmode = self.operation_mode()
352352
if operationmode is not None:
353-
for mode in operationmode["values"]:
354-
ha_mode = DAIKIN_HVAC_TO_HA[mode]
355-
if ha_mode not in modes:
356-
modes.append(ha_mode)
353+
if operationmode["settable"] is True:
354+
for mode in operationmode["values"]:
355+
ha_mode = DAIKIN_HVAC_TO_HA[mode]
356+
if ha_mode not in modes:
357+
modes.append(ha_mode)
358+
currentmode = operationmode["value"]
359+
ha_currentmode = DAIKIN_HVAC_TO_HA[currentmode]
360+
if ha_currentmode not in modes:
361+
modes.append(ha_currentmode)
357362
return modes
358363

359364
async def async_set_hvac_mode(self, hvac_mode):

tests/snapshots/test_init.ambr

-8
Original file line numberDiff line numberDiff line change
@@ -70279,11 +70279,7 @@
7027970279
]),
7028070280
'hvac_modes': list([
7028170281
<HVACMode.OFF: 'off'>,
70282-
<HVACMode.FAN_ONLY: 'fan_only'>,
7028370282
<HVACMode.HEAT: 'heat'>,
70284-
<HVACMode.COOL: 'cool'>,
70285-
<HVACMode.HEAT_COOL: 'heat_cool'>,
70286-
<HVACMode.DRY: 'dry'>,
7028770283
]),
7028870284
'max_temp': 31,
7028970285
'min_temp': 10,
@@ -70341,11 +70337,7 @@
7034170337
'friendly_name': 'Studio Room Temperature',
7034270338
'hvac_modes': list([
7034370339
<HVACMode.OFF: 'off'>,
70344-
<HVACMode.FAN_ONLY: 'fan_only'>,
7034570340
<HVACMode.HEAT: 'heat'>,
70346-
<HVACMode.COOL: 'cool'>,
70347-
<HVACMode.HEAT_COOL: 'heat_cool'>,
70348-
<HVACMode.DRY: 'dry'>,
7034970341
]),
7035070342
'max_temp': 31,
7035170343
'min_temp': 10,

0 commit comments

Comments
 (0)