Merge branch 'master' into jwi-logresponsetext

Author: jwillemsen

custom_components/daikin_onecta/climate.py

@@ -318,22 +318,23 @@ async def async_set_temperature(self, **kwargs):
             await self.async_set_hvac_mode(kwargs[ATTR_HVAC_MODE])
 
         if ATTR_TEMPERATURE in kwargs:
-            operationmode = self.operation_mode()
-            omv = operationmode["value"]
             value = kwargs[ATTR_TEMPERATURE]
-            res = await self._device.patch(
-                self._device.id,
-                self._embedded_id,
-                "temperatureControl",
-                f"/operationModes/{omv}/setpoints/{self._setpoint}",
-                value,
-            )
-            # When updating the value to the daikin cloud worked update our local cached version
-            if res:
-                setpointdict = self.setpoint()
-                if setpointdict is not None:
-                    self._attr_target_temperature = value
-                    self.async_write_ha_state()
+            if self._attr_target_temperature != value:
+                operationmode = self.operation_mode()
+                omv = operationmode["value"]
+                res = await self._device.patch(
+                    self._device.id,
+                    self._embedded_id,
+                    "temperatureControl",
+                    f"/operationModes/{omv}/setpoints/{self._setpoint}",
+                    value,
+                )
+                # When updating the value to the daikin cloud worked update our local cached version
+                if res:
+                    setpointdict = self.setpoint()
+                    if setpointdict is not None:
+                        self._attr_target_temperature = value
+                        self.async_write_ha_state()
 
     def get_hvac_mode(self):
         """Return current HVAC mode."""

custom_components/daikin_onecta/manifest.json

@@ -8,5 +8,5 @@
   "iot_class": "cloud_polling",
   "issue_tracker": "https://github.com/jwillemsen/daikin_onecta/issues",
   "requirements": [],
-  "version": "4.1.5"
+  "version": "4.1.7"
 }

custom_components/daikin_onecta/water_heater.py

@@ -186,17 +186,19 @@ async def async_set_tank_temperature(self, value):
                     self._device.name,
                 )
                 return None
-        res = await self._device.patch(
-            self._device.id,
-            self._embedded_id,
-            "temperatureControl",
-            "/operationModes/heating/setpoints/domesticHotWaterTemperature",
-            int(value),
-        )
-        # When updating the value to the daikin cloud worked update our local cached version
-        if res:
-            self._attr_target_temperature = value
-            self.async_write_ha_state()
+
+        if int(value) != self._attr_target_temperature:
+            res = await self._device.patch(
+                self._device.id,
+                self._embedded_id,
+                "temperatureControl",
+                "/operationModes/heating/setpoints/domesticHotWaterTemperature",
+                int(value),
+            )
+            # When updating the value to the daikin cloud worked update our local cached version
+            if res:
+                self._attr_target_temperature = value
+                self.async_write_ha_state()
 
     async def async_set_temperature(self, **kwargs):
         """Set new target temperature."""

readme.md

@@ -38,8 +38,6 @@ You will now be redirected to the Daikin website where you have to authorize the
 
 Only when the redirect back to your Home Assistant doesn't work first try to install/enable [My Home Assistant](https://www.home-assistant.io/integrations/my/). When that also doesn't work you can try `<HOME_ASSISTANT_URL>/auth/external/callback` as the redirect URI instead. The `<HOME_ASSISTANT_URL>` must be the same as used during the configuration/authentication process. Internal examples: `http://192.168.0.2:8123/auth/external/callback`, `http://homeassistant.local:8123/auth/external/callback`.
 
-When you try to reinstall this integration check if you don't have an old client id and secret configured within Home Assistant, see [Application Credentials](https://www.home-assistant.io/integrations/application_credentials/) for more information.
-
 This integration supports the following configuration settings to reduce the amount of polling to Daikin
 
 - High frequency period update interval (minutes)
@@ -48,6 +46,10 @@ This integration supports the following configuration settings to reduce the amo
 - Low frequency period start time
 - Number of seconds that a data refresh is ignored after a command
 
+# Reinstall
+
+When you try to reinstall this integration check if you don't have an old client id and secret configured within Home Assistant, see [Application Credentials](https://www.home-assistant.io/integrations/application_credentials/) for more information.
+
 # Setting the log level
 
 If you'd like to see more granular logs, to investigate the communication or for other debugging purposes, you can set the log level in the Home Assistant config. The following lines can be added to set the overall log level for the component and the oauth2 helper which this integration uses:

tests/test_init.py

@@ -296,6 +296,17 @@ async def test_water_heater(
         assert responses.calls[0].request.body == '{"value": 58, "path": "/operationModes/heating/setpoints/domesticHotWaterTemperature"}'
         assert hass.states.get("water_heater.altherma").attributes["temperature"] == 58
 
+        # Set the tank temperature to 58, this should not result in a call as it is already 58
+        await hass.services.async_call(
+            WATER_HEATER_DOMAIN,
+            SERVICE_SET_TEMPERATURE,
+            {ATTR_ENTITY_ID: "water_heater.altherma", ATTR_TEMPERATURE: 58},
+            blocking=True,
+        )
+        await hass.async_block_till_done()
+
+        assert len(responses.calls) == 1
+
         # Set the tank off, this should just work
         await hass.services.async_call(
             WATER_HEATER_DOMAIN,
@@ -637,6 +648,17 @@ async def test_climate(
         assert responses.calls[10].request.body == '{"value": 25.0, "path": "/operationModes/heating/setpoints/roomTemperature"}'
         assert hass.states.get("climate.werkkamer_room_temperature").attributes["temperature"] == 25
 
+        # Set the target temperature another time to 25, should not result in a call to Daikin
+        await hass.services.async_call(
+            CLIMATE_DOMAIN,
+            SERVICE_SET_TEMPERATURE,
+            {ATTR_ENTITY_ID: "climate.werkkamer_room_temperature", ATTR_TEMPERATURE: 25},
+            blocking=True,
+        )
+        await hass.async_block_till_done()
+
+        assert len(responses.calls) == 11
+
         # Set the hvac mode to cool and target temperature to 20 using one call
         await hass.services.async_call(
             CLIMATE_DOMAIN,