Skip to content

Commit b64105b

Browse files
committed
Fix new command.
1 parent 6add4c2 commit b64105b

File tree

7 files changed

+12
-14
lines changed

7 files changed

+12
-14
lines changed

cmd/new.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,11 @@ import (
3030
"os"
3131
"path/filepath"
3232

33+
"github.com/goccy/go-yaml"
3334
"github.com/k1LoW/runn"
3435
"github.com/k1LoW/runn/capture"
3536
"github.com/mattn/go-isatty"
3637
"github.com/spf13/cobra"
37-
"gopkg.in/yaml.v2"
3838
)
3939

4040
// newCmd represents the new command.

cmdout.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ func (d *cmdOut) verboseOutResultForStep(idx int, sr *StepResult, path string, n
118118
case sr.Err != nil:
119119
// fail
120120
lineformat := indent + " %s\n"
121-
_, _ = fmt.Fprintf(d.out, "%s --- %s(%s) ... %s\n%s", indent, desc, sr.Key, red("fail"), red(SprintMultilinef(lineformat, "Failure/Error: %s", strings.TrimRight(sr.Err.Error(), "\n"))))
121+
_, _ = fmt.Fprintf(d.out, "%s --- %s(%s) ... %s\n%s", indent, desc, sr.Key, red("fail"), red(sprintMultilinef(lineformat, "Failure/Error: %s", strings.TrimRight(sr.Err.Error(), "\n"))))
122122
if len(sr.IncludedRunResults) > 0 {
123123
for _, ir := range sr.IncludedRunResults {
124124
_, _ = fmt.Fprintf(d.out, "%s === %s (%s)\n", indent, ir.Desc, ir.Path)
@@ -136,7 +136,7 @@ func (d *cmdOut) verboseOutResultForStep(idx int, sr *StepResult, path string, n
136136
return
137137
}
138138
_, _ = fmt.Fprintf(d.out, "%s Failure step (%s):\n", indent, path)
139-
_, _ = fmt.Fprint(d.out, SprintMultilinef(lineformat, "%v", picked))
139+
_, _ = fmt.Fprint(d.out, sprintMultilinef(lineformat, "%v", picked))
140140
_, _ = fmt.Fprintln(d.out, "")
141141
case sr.Skipped:
142142
// skip

go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@ require (
7777
golang.org/x/sync v0.10.0
7878
google.golang.org/grpc v1.69.0
7979
google.golang.org/protobuf v1.35.2
80-
gopkg.in/yaml.v2 v2.4.0
8180
modernc.org/sqlite v1.34.2
8281
)
8382

@@ -208,6 +207,7 @@ require (
208207
google.golang.org/genproto v0.0.0-20241113202542-65e8d215514f // indirect
209208
google.golang.org/genproto/googleapis/api v0.0.0-20241104194629-dd2ea8efbc28 // indirect
210209
google.golang.org/genproto/googleapis/rpc v0.0.0-20241118233622-e639e219e697 // indirect
210+
gopkg.in/yaml.v2 v2.4.0 // indirect
211211
gopkg.in/yaml.v3 v3.0.1 // indirect
212212
modernc.org/gc/v3 v3.0.0-20240107210532-573471604cb6 // indirect
213213
modernc.org/libc v1.55.3 // indirect

result.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ func (rr *RunResult) outFailure(out io.Writer, index int) (int, error) {
193193
for iii, pp := range p[1:] {
194194
_, _ = fmt.Fprintf(out, " %s%s %s\n", strings.Repeat(" ", iii), tr, pp)
195195
}
196-
_, _ = fmt.Fprint(out, SprintMultilinef(" %s\n", "%v", red(fmt.Sprintf("Failure/Error: %s", strings.TrimRight(errs[ii].Error(), "\n")))))
196+
_, _ = fmt.Fprint(out, sprintMultilinef(" %s\n", "%v", red(fmt.Sprintf("Failure/Error: %s", strings.TrimRight(errs[ii].Error(), "\n")))))
197197

198198
last := p[len(p)-1]
199199
b, err := readFile(last)
@@ -208,7 +208,7 @@ func (rr *RunResult) outFailure(out io.Writer, index int) (int, error) {
208208
return index, err
209209
}
210210
_, _ = fmt.Fprintf(out, " Failure step (%s):\n", normalizePath(last))
211-
_, _ = fmt.Fprint(out, SprintMultilinef(" %s\n", "%v", picked))
211+
_, _ = fmt.Fprint(out, sprintMultilinef(" %s\n", "%v", picked))
212212
_, _ = fmt.Fprintln(out, "")
213213
}
214214

@@ -326,7 +326,7 @@ func simplifyStepResults(stepResults []*StepResult) []*stepResultSimplified {
326326
return simplified
327327
}
328328

329-
func SprintMultilinef(lineformat, format string, a ...any) string {
329+
func sprintMultilinef(lineformat, format string, a ...any) string {
330330
lines := strings.Split(fmt.Sprintf(format, a...), "\n")
331331
var formatted string
332332
for _, l := range lines {

runbook.go

+2-5
Original file line numberDiff line numberDiff line change
@@ -189,12 +189,9 @@ func (rb *runbook) AppendStep(in ...string) error {
189189
return rb.curlToStep(in...)
190190
case strings.HasPrefix(in[0], "grpcurl"):
191191
return rb.grpcurlToStep(in...)
192+
case len(in) == 1:
193+
return rb.axsLogToStep(in...)
192194
default:
193-
if len(in) == 1 {
194-
if err := rb.axsLogToStep(in...); err == nil {
195-
return nil
196-
}
197-
}
198195
return rb.cmdToStep(in...)
199196
}
200197
}

store.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,13 @@ const (
3131

3232
const (
3333
storeStepKeyOutcome = "outcome"
34+
storeFuncValue = "[func]"
3435
)
3536

37+
// `runn` is global store for runn.
3638
const (
3739
storeRunnKeyKV = "kv"
3840
storeRunnKeyRunNIndex = "i"
39-
storeFuncValue = "[func]"
4041
storeRunnKeyStdin = "stdin"
4142
)
4243

test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ func newCondFalseError(cond, tree string) *condFalseError {
2424
}
2525

2626
func (fe *condFalseError) Error() string {
27-
tree := SprintMultilinef(" %s\n", "%s", fe.tree)
27+
tree := sprintMultilinef(" %s\n", "%s", fe.tree)
2828
return fmt.Sprintf("condition is not true\n\nCondition:\n%s", tree)
2929
}
3030

0 commit comments

Comments
 (0)