* Support for fahrenheit temperature unit

* Usage of temperature min. and max. values from geckolib

Author: munstfr

.vscode/settings.json

@@ -1,6 +1,8 @@
 {
     "cSpell.words": [
         "asyncio",
+        "Bromi",
+        "cjson",
         "cmnd",
         "gazoodle",
         "geckoclient",
@@ -11,10 +13,14 @@
         "NOTSET",
         "OZONEMODE",
         "paho",
+        "PUMPNUMBER",
+        "Setpoint",
         "signum",
         "SIGTERM",
         "SMARTWINTERMODE",
         "spaman",
+        "SPAXX",
+        "userdata",
         "watercare",
         "WATERHEAT"
     ]

README.md

@@ -106,7 +106,7 @@ Since version 0.6.x the SPA is controlled by only one control topic `%prefix%/co
 | Item | JSON String                                           | Comment |
 | ---- |-------------------------------------------------------| --- |
 | Lights | {"lights":"off|on"}                              |
-| Temperature | {"temp":TEMP}                                         | TEMP is between 15.0 and 40.0 in steps of 0.5 |
+| Temperature | {"temp":TEMP}                                         | TEMP is in steps of 0.5 |
 | Pumps | {"pump":"off|low|high","number":PUMPNUMBER} | Not all SPA support 'low' value |
 | Blower | {"blower":"off|high"}                            |
 | Watercare | {"watercare":"MODE"}                                  | See below for possible MODE values | 
@@ -178,6 +178,10 @@ https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12
 
 # History
 
+### v0.6.1
+* Support for fahrenheit temperature unit
+* Usage of temperature min. and max. values from geckolib
+
 ### v0.6.0
 * Breaking change
 * Switch to one command topic and change value to json format

src/const.py

@@ -6,7 +6,11 @@
 # GeckoClient version
 GECKO_CLIENT_VERSION = "0.6.0"
 
+#############
 # internal constants, please do not change
+#######
+
+# topics sub-names
 TOPIC_CONTROL = TOPIC+"/control"
 TOPIC_LIGHTS = TOPIC+"/lights"
 TOPIC_REMINDERS = TOPIC+"/reminders"

src/mySpa.py

@@ -12,7 +12,7 @@
 from geckolib import (GeckoSpaEvent, GeckoSpaState)
 from geckolib import GeckoAsyncSpaMan
 
-from geckolib import (GeckoWaterCare, GeckoReminders, GeckoStructAccessor)
+from geckolib import (GeckoWaterCare, GeckoReminders, GeckoStructAccessor, GeckoWaterHeater)
 
 from geckolib import GeckoConstants
 
@@ -47,11 +47,13 @@ async def handle_event(self, event: GeckoSpaEvent, **kwargs) -> None:
         if event == GeckoSpaEvent.CLIENT_FACADE_IS_READY:
 
             logger.info("SPA facade is ready.")
-            self._can_use_facade = True
 
             # at least publish once all values once
             await self._refreshAll()
 
+            # now we can use the facade
+            self._can_use_facade = True
+
             # add the watcher to see all changes
             self._facade.watch(OnChange(self))
 
@@ -380,7 +382,13 @@ async def controls(self, client, userdata, message):
             except Exception as ex:
                 logger.warning(f"Wrong temperature value received")
                 return
-            if temp < 6 and temp > 40:
+            check_failed = False
+            if self._facade.water_heater.temperature_unit == GeckoWaterHeater.TEMP_CELCIUS:
+                if temp < GeckoWaterHeater.MIN_TEMP_C or temp > GeckoWaterHeater.MAX_TEMP_C:
+                    check_failed = True
+            elif temp < GeckoWaterHeater.MIN_TEMP_F or temp > GeckoWaterHeater.MAX_TEMP_F:
+                check_failed = True
+            if check_failed:
                 logger.warning(f"Temperature {temp} outside allowed values")
                 return
             await self._facade.water_heater.set_target_temperature(temp)
@@ -445,6 +453,9 @@ def __call__(self, sender, old_value, new_value):
             elif sender.tag == "Clean" or sender.tag == "Purge":
                 self._mySpa.refreshFilters()
 
+            elif sender.tag == "TempUnits":
+                self._mySpa.refreshHeater()
+
             else:
                 logger.warning(f"Not handled GeckoStructAccessor sender tag received: {sender.tag}")
                 logger.warning(f"  --> {sender} changed from {old_value} to {new_value}")