UNION_MEMBER_ADDED is no longer a breaking change but dangerous (#1014)

Author: kamilkisiela

CHANGELOG.md

@@ -2,7 +2,8 @@
 
 ### vNEXT
 
-- **core** **cli** introduce `keepClientFields` flag in `validate` [PR #783](https://github.com/kamilkisiela/graphql-inspector/pull/783)
+- **core** **cli**: introduce `keepClientFields` flag in `validate` [PR #783](https://github.com/kamilkisiela/graphql-inspector/pull/783)
+- **core**: `UNION_MEMBER_ADDED` is no longer a breaking change but dangerous
 
 ### v1.26.0
 

actions/cleanup/package.json

@@ -3,6 +3,6 @@
   "version": "1.0.0",
   "license": "MIT",
   "dependencies": {
-    "actions-toolkit": "2.1.0"
+    "actions-toolkit": "2.2.0"
   }
 }

actions/merged/package.json

@@ -3,6 +3,6 @@
   "version": "1.0.0",
   "license": "MIT",
   "dependencies": {
-    "actions-toolkit": "2.1.0"
+    "actions-toolkit": "2.2.0"
   }
 }

lib/action.js

@@ -51,7 +51,6 @@
   "devDependencies": {
     "@types/express": "4.17.2",
     "@types/figures": "3.0.1",
-    "@types/graphql": "14.5.0",
     "@types/indent-string": "4.0.1",
     "@types/jest": "24.0.25",
     "@types/log-symbols": "3.0.0",

packages/cli/package.json

@@ -37,7 +37,7 @@ describe('union', () => {
 
     const change = findFirstChangeByPath(changes, 'Foo');
 
-    expect(change.criticality.level).toEqual(CriticalityLevel.Breaking);
+    expect(change.criticality.level).toEqual(CriticalityLevel.Dangerous);
     expect(change.type).toEqual('UNION_MEMBER_ADDED');
     expect(change.message).toEqual("Member 'C' was added to Union type 'Foo'");
   });

packages/core/__tests__/diff/union.ts

@@ -33,8 +33,8 @@
     "dependency-graph": "0.8.1"
   },
   "devDependencies": {
-    "@types/graphql": "14.5.0",
     "@types/jest": "24.0.25",
+    "graphql": "14.5.8",
     "graphql-tag": "2.10.1",
     "jest": "24.9.0",
     "ts-jest": "24.2.0",

packages/core/package.json

@@ -23,7 +23,7 @@ export function unionMemberAdded(
 ): Change {
   return {
     criticality: {
-      level: CriticalityLevel.Breaking,
+      level: CriticalityLevel.Dangerous,
       reason:
         'Adding a possible type to Unions may break existing clients that were not programming defensively against a new possible type.',
     },

packages/core/src/diff/changes/union.ts

@@ -15,8 +15,8 @@ export function changesInEnum(
   newEnum: GraphQLEnumType,
 ): Change[] {
   const changes: Change[] = [];
-  const oldNames = oldEnum.getValues().map(v => v.value);
-  const newNames = newEnum.getValues().map(v => v.value);
+  const oldNames = oldEnum.getValues().map(v => v.name);
+  const newNames = newEnum.getValues().map(v => v.name);
 
   const added = diffArrays(newNames, oldNames).map(
     name => newEnum.getValue(name) as GraphQLEnumValue,

packages/core/src/diff/enum.ts

@@ -35,13 +35,11 @@
     "@actions/core": "1.2.0",
     "@actions/github": "2.0.0",
     "@graphql-inspector/github": "0.0.0-PLACEHOLDER",
-    "actions-toolkit": "2.2.0",
     "graphql": "14.5.8",
     "js-yaml": "3.13.1",
     "probot": "9.8.0"
   },
   "devDependencies": {
-    "@types/graphql": "14.5.0",
     "@types/js-yaml": "3.12.1",
     "@types/node": "13.1.2",
     "typescript": "3.7.4"

packages/github-actions/package.json

@@ -2,7 +2,7 @@
   userAgent: 'node.js',
 };
 
-import * as core from '@actions/core';
+import core from '@actions/core';
 import {run} from './run';
 
 run().catch(e => {

packages/github-actions/src/action.ts

@@ -1,6 +1,6 @@
 #!/usr/bin/env node
 
-import * as core from '@actions/core';
+import core from '@actions/core';
 import {run} from './run';
 
 run().catch(e => {

packages/github-actions/src/index.ts

@@ -1,14 +1,14 @@
-import {SchemaPointer} from '@graphql-inspector/github/dist/probot';
 import {
+  SchemaPointer,
   ActionResult,
   CheckConclusion,
   Annotation,
-} from '@graphql-inspector/github/dist/types';
-import {diff} from '@graphql-inspector/github/dist/diff';
+  diff,
+} from '@graphql-inspector/github';
 import {buildSchema} from 'graphql';
 
-import * as core from '@actions/core';
-import * as github from '@actions/github';
+import core from '@actions/core';
+import github from '@actions/github';
 import {ChecksUpdateParams} from '@octokit/rest';
 
 const CHECK_NAME = 'GraphQL Inspector';

packages/github-actions/src/run.ts

@@ -42,7 +42,6 @@
   },
   "devDependencies": {
     "@types/express": "4.17.2",
-    "@types/graphql": "14.5.0",
     "graphql": "14.5.8",
     "probot": "9.8.0",
     "smee-client": "1.1.0",

packages/github/package.json

@@ -2,3 +2,6 @@ import appFn, {handleAction} from './probot';
 
 export default appFn;
 export {handleAction};
+export {ActionResult, CheckConclusion, Annotation} from './types';
+export {SchemaPointer} from './probot';
+export {diff} from './diff';

packages/github/src/index.ts

@@ -1,13 +1,12 @@
 import {Source, print} from 'graphql';
-import {loadDocumentsUsingLoaders} from '@graphql-toolkit/core';
+import {loadDocuments as toolkitLoadDocuments} from '@graphql-toolkit/core';
 import {GraphQLFileLoader} from '@graphql-toolkit/graphql-file-loader';
 import {CodeFileLoader} from '@graphql-toolkit/code-file-loader';
 
 export async function loadDocuments(pointer: string): Promise<Source[]> {
-  const documents = await loadDocumentsUsingLoaders(
-    [new GraphQLFileLoader(), new CodeFileLoader()],
-    pointer,
-  );
+  const documents = await toolkitLoadDocuments(pointer, {
+    loaders: [new GraphQLFileLoader(), new CodeFileLoader()],
+  });
 
-  return documents.map(doc => new Source(print(doc.document), doc.location));
+  return documents.map(doc => new Source(print(doc.document!), doc.location));
 }

packages/load/src/documents.ts

@@ -1,5 +1,5 @@
 import {GraphQLSchema, isSchema} from 'graphql';
-import {loadSchemaUsingLoaders} from '@graphql-toolkit/core';
+import {loadSchema as toolkitLoadSchema} from '@graphql-toolkit/core';
 import {GraphQLFileLoader} from '@graphql-toolkit/graphql-file-loader';
 import {CodeFileLoader} from '@graphql-toolkit/code-file-loader';
 import {GitLoader} from '@graphql-toolkit/git-loader';
@@ -11,18 +11,17 @@ export async function loadSchema(
   pointer: string,
   extra?: any,
 ): Promise<GraphQLSchema> {
-  const resolved = await loadSchemaUsingLoaders(
-    [
+  const resolved = await toolkitLoadSchema(pointer, {
+    loaders: [
       new GitLoader(),
       new GithubLoader(),
       new GraphQLFileLoader(),
       new JsonFileLoader(),
       new UrlLoader(),
       new CodeFileLoader(),
     ],
-    pointer,
-    extra || {},
-  );
+    ...(extra || {}),
+  });
 
   if (isSchema(resolved)) {
     return resolved;

packages/load/src/schema/index.ts

@@ -9,18 +9,20 @@ module.exports = {
     filename: 'action.js',
   },
   resolve: {
-    extensions: ['.ts', '.ts', '.js', '.json'],
+    extensions: ['.ts', '.js', '.json'],
   },
   module: {
     rules: [
       {
         test: /\.ts$/,
         exclude: /node_modules/,
         loader: 'ts-loader',
+        options: {
+          transpileOnly: true,
+        },
       },
       {
         test: /\.mjs$/,
-        include: /node_modules/,
         type: 'javascript/auto',
       },
     ],