Chore: address invalid Base64 encoding (/pieroxy/issues/110)

Author: karnthis

src/base64/betterBase64.ts

@@ -1,10 +1,33 @@
-import { decompressFromBase64 } from "./decompressFromBase64";
-import { compressToBase64 } from "./compressToBase64";
+import { _compress } from "../_compress";
+import keyStrBase64 from "./keyStrBase64";
+import { _decompress } from "../_decompress";
+import { getBaseValue } from "../getBaseValue";
 
 export function compressToBetterBase64(input: string): string {
-    return compressToBase64(input) || "";
+    if (!input) {
+        return "";
+    }
+    const res = _compress(input, 6, (a) => keyStrBase64.charAt(a));
+
+    // To produce valid Base64
+    switch (res.length % 3) {
+        case 0:
+            return res;
+        case 1:
+            return res + "==";
+        case 2:
+            return res + "=";
+        default: // When could this happen ?
+            console.warn("Something in compressToBetterBase64() is very very wrong.");
+            return "";
+    }
+
 }
 
 export function decompressFromBetterBase64(input: string): string {
-    return decompressFromBase64(input) || "";
+    if (!input) {
+        return "";
+    }
+    const res = _decompress(input.length, 32, (index) => getBaseValue(keyStrBase64, input.charAt(index)));
+    return res || "";
 }

src/base64/compressToBase64.ts

@@ -1,7 +1,9 @@
 import { _compress } from "../_compress";
 import keyStrBase64 from "./keyStrBase64";
+import { deprecated } from "../utils/misc";
 
 export function compressToBase64(input: string | null): string {
+    deprecated("compressToBase64()", "v2.0.0", { replacement: "compressToBetterBase64()"})
     if (input == null) {
         return "";
     }

src/base64/decompressFromBase64.ts

@@ -1,8 +1,10 @@
 import { _decompress } from "../_decompress";
 import { getBaseValue } from "../getBaseValue";
 import keyStrBase64 from "./keyStrBase64";
+import { deprecated } from "../utils/misc";
 
 export function decompressFromBase64(input: string | null) {
+    deprecated("decompressFromBase64()", "v2.0.0", { replacement: "decompressFromBetterBase64()"})
     if (input == null) return "";
     if (input == "") return null;
 

src/utils/misc.ts

@@ -0,0 +1,14 @@
+type VERSIONS = "v2.0.0"
+
+export function deprecated(
+    thing: string,
+    version: VERSIONS,
+    opts?: { aggressive?: boolean; replacement?: string }
+): void {
+    let notice = `LZString | ${thing} is deprecated as of: ${version}`
+    if (opts?.replacement) {
+        notice += ` - Please use ${opts.replacement} instead`
+    }
+    console.error(notice)
+    if (window && opts?.aggressive) alert(notice)
+}