Potential leak in ImagePipelineDelgate

[prabhuamol]

Hi
Should the ImagePipelineDelgate be declared as weak var. We are seeing a leak in the app regarding this.

We have ImagePipeline declared as a lazy var in a Class, this results in a retain cycle and a leak

   lazy var imagePipeline: ImagePipeline = {
        return .init(configuration: configuration, delegate: self)
   }()

I have a PR open here #806

Thanks in advance!

[prabhuamol]

Looks like tests will fail as ImagePipelineDefaultDelgate wont hang around since its now weak. Hmm guess you cant have self as delegate like we are doing in order to avoid retain cycle

Should we be doing something like this

lazy var imagePipeline: ImagePipeline = {
        return .init(configuration: configuration, delegate: RemoteImagePipelineDelgate())
   }()

[kean]

The design matches URLSession where the delegate is also retained. It doesn't necessarily have to be, but it's more convenient for some scenarios.

[prabhuamol]

Fair enough, we'll change our implementation accordingly. Maybe worth mentioning this in the doc as delegate are generally assumed to be weak

[prabhuamol]

wonder if my other change here makes sense #806