Adds poseidon_hash_bn254(x, y) in garaga_rs with Js and Python bindings. (#307)

Author: feltroidprime

Makefile

@@ -27,6 +27,8 @@ ci-cairo:
 ci-wasm:
 	./tools/make/ci_wasm.sh
 
+wasm:
+	./tools/make/wasm.sh
 clean:
 	rm -rf build/compiled_cairo_files
 	mkdir -p build

hydra/garaga/precompiled_circuits/poseidon_bn254.py

@@ -1,5 +1,5 @@
 from garaga.definitions import CurveID, get_base_field
-from garaga.modulo_circuit import ModuloCircuit
+from garaga.modulo_circuit import ModuloCircuit, ModuloCircuitElement
 from garaga.modulo_circuit_structs import u384
 
 # Global circuit definition
@@ -73,8 +73,19 @@ def mix_s(t, S, r, state):
     return result
 
 
-def poseidon_hash(x, y):
+def poseidon_hash(
+    x: ModuloCircuitElement, y: ModuloCircuitElement
+) -> ModuloCircuitElement:
     """Computes the Poseidon hash for two inputs x and y."""
+    if isinstance(x, int):
+        x = circuit.write_element(x)
+    if isinstance(y, int):
+        y = circuit.write_element(y)
+    if not isinstance(x, ModuloCircuitElement) or not isinstance(
+        y, ModuloCircuitElement
+    ):
+        raise ValueError("x and y must be ModuloCircuitElement instances")
+
     t = 3  # 2 inputs + 1 state
     n_rounds_f = 8  # Full rounds
     n_rounds_p = 57  # Partial rounds
@@ -532,12 +543,13 @@ def poseidon_hash(x, y):
     return mix_last(t, POSEIDON_M, 0, state)
 
 
-# Compute the Poseidon hash
-z = poseidon_hash(x, y)
+if __name__ == "__main__":
+    # Compute the Poseidon hash
+    z = poseidon_hash(x, y)
 
-# Define the output of the circuit
-circuit.extend_struct_output(u384("z", [z]))
+    # Define the output of the circuit
+    circuit.extend_struct_output(u384("z", [z]))
 
-# Compile and print the compiled circuit
-compiled_code, function_name = circuit.compile_circuit()
-print(compiled_code)
+    # Compile and print the compiled circuit
+    compiled_code, function_name = circuit.compile_circuit()
+    print(compiled_code)

tests/hydra/test_poseidon_hash.py

@@ -0,0 +1,43 @@
+import time
+
+import pytest
+
+from garaga import garaga_rs
+from garaga.precompiled_circuits.poseidon_bn254 import poseidon_hash
+
+
+def test_poseidon_hash_bn254():
+    # Test with valid inputs
+    x = 1
+    y = 2
+    expected = 0x115CC0F5E7D690413DF64C6B9662E9CF2A3617F2743245519E19607A4417189A
+
+    tr0 = time.time()
+    for _ in range(20):
+        result = garaga_rs.poseidon_hash_bn254(x, y)
+    tr1 = time.time()
+    print(f"Garaga RS time: {tr1 - tr0} seconds")
+    assert result == expected
+
+    tp0 = time.time()
+    for _ in range(20):
+        result = poseidon_hash(x, y)
+    tp1 = time.time()
+
+    print(f"Garaga Python time: {tp1 - tp0} seconds")
+    assert result.value == expected
+
+    # Test different inputs give different results
+    result2 = garaga_rs.poseidon_hash_bn254(2, 1)
+    assert result != result2
+
+    # Test with large numbers
+    x_large = 2**255 - 1
+    y_large = 2**255 - 2
+    result = garaga_rs.poseidon_hash_bn254(x_large, y_large)
+    assert isinstance(result, int)
+    assert len(hex(result)[2:]) <= 64  # Result should be within field size
+
+    # Test invalid inputs
+    with pytest.raises(OverflowError):
+        garaga_rs.poseidon_hash_bn254(-1, 1)  # Negative numbers not allowed

tools/garaga_rs/Cargo.lock

@@ -45,6 +45,7 @@ hex = "0.4"
 sha2 = "0.10"
 sha3 = "0.10"
 js-sys = "0.3"
+lazy_static = "1.4"
 starknet-types-core = { version = "0.1.7", default-features = false, features = ["curve"] }
 lambdaworks-crypto = { git = "https://github.com/lambdaclass/lambdaworks.git" }
 lambdaworks-math = { git = "https://github.com/lambdaclass/lambdaworks.git" }

tools/garaga_rs/Cargo.toml

@@ -0,0 +1,2 @@
+#[allow(dead_code)]
+pub mod poseidon_bn254;