Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements of new filter functionality #5845

Open
2 of 20 tasks
MilosPaunovic opened this issue Nov 7, 2024 · 2 comments
Open
2 of 20 tasks

Improvements of new filter functionality #5845

MilosPaunovic opened this issue Nov 7, 2024 · 2 comments
Assignees
Labels
area/frontend Needs frontend code changes enhancement New feature or request

Comments

@MilosPaunovic
Copy link
Member

MilosPaunovic commented Nov 7, 2024

Right now, there are new filters only on Executions page. It's not yet fully completed, but it's being merged so I can get more feedback from the rest of the team.

Below is the list of known issues and tasks to be implemented, anything else you find or notice, feel free to add as comment below and it will be amended.

  • Implement search triggering on adding new filter value (full adding), as now it is confusing why the content is not filtered when we chose filters (we can remove the search button itself, maybe involves a bot of work around the recent functionality).
  • Allow selection of values in dropdown on Enter key press.
  • Add complete keyboard navigation as part of dropdowns.
  • Submit filter query on Enter key press.
  • Improve highlighting of already selected items in second and third dropdowns.
  • Replace usage of filters throughout the application & add missing filters.
  • Add button to handle the table options (selection of visible columns), this should be an option on the table itself.
  • If there already is property with same label and comparator, add value to it instead creation of new tag.
  • If property is marked as multiple, only then allow multiple values, if not, replace existing value with new one.
  • Limit the width of the dropdown menu with options.
  • Parameters decoder on page reload is not adding proper comparator value.
  • Make the comparators ("is" and such), along with the colon characters around it be in primary color to improve readability (specially since text is incredibly small).
  • Make sure to not allow duplicate values in recent listing (to think about preventing duplicates in saved).
  • When selecting Absolute date as filter, and getting to third dropdown, open the date picker automatically.
  • Make labels for Absolute date filter in humanly readable format using Intl instead of standard date format.
  • Page filter dropdown at the right end looks like a tooltip, make it a bit lighter in dark mode.
  • Make filters expand fully if we omit some of the non required buttons #5912
  • Amend filter placeholder font color #5911
  • Add button to handle the page settings (show charts). #5905
  • Add remaining filter options for Executions context (Relative date, Absolute date). #5898

Related issue #4664.

@MilosPaunovic MilosPaunovic added enhancement New feature or request area/frontend Needs frontend code changes labels Nov 7, 2024
@MilosPaunovic MilosPaunovic self-assigned this Nov 7, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Issues Nov 7, 2024
@elevatebart
Copy link
Contributor

notes from Demo

The options popper at the end of the filter bar looks like a tooltip. Could we make the content a little lighter in dark mode? (might be element plus)
Placeholder color looks exactly like paragraph text. Is it normal? It does not feel normal.
Could we have the comparator ("is") be in a different color to improve readability (specially since text is incredibly small)
Date filters ideas

  • inspire from gmail search (great readability)
  • dates should be humanly readable instead of std date format (use Intl)

@MilosPaunovic
Copy link
Member Author

Updated the issue description with Bart's notes from the comment above, and, with notes from the rest of the team collected during the demo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Needs frontend code changes enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

2 participants