Executions filter still is applied even if user canceled it

[smunteankestra]

Describe the issue

Step 1 : Add a filter
Step 2 : remove it by pressing the X cross on it
Step 3: Refresh
Expected: filter to be removed
Actual: Filter remains

Screen.Recording.2024-11-11.at.10.31.44.mov

Environment

• Kestra Version: develop

[sarthakvijayvargiya]

Hi @MilosPaunovic Can i work on this.

[MilosPaunovic]

You can, but as this is a part of our new filters overhaul, I'll take over tomorrow if there's no PR submitted by then.

New filters are now shown only on Executions page (that is the name of the component, as well) so you can start there.

[MilosPaunovic]

So, I've looked at this, and, as of this moment, it is expected behavior, as the search is being triggered only when we click the search button to the right.

We can update the expected outcome for the filters to be updated every time we remove a tag, like Stefan did here. Is that what we want from the product perspective @Ben8t?

[Ben8t]

Yes, I think the expected behavior from Stephan is the good one. Can we apply this to only "remove" action and not "add filter" (seeing the UI blinking every time a user add a filter doesn't sounds right in this case).

FYI, on GitHub Project filter, everything is applied at every change... (which make the UI blink a lot; not very UX friendly IMO, especially on adds)

[MilosPaunovic]

Agreed, will make the necessary change.

[MilosPaunovic]

Even better, @sarthakvijayvargiya, are you willing to have this as your first contribution, with a bit of help from my side?

You need to edit the kestra/ui/src/components/filter/Wrapper.vue component and add this router.push({query: encodeParams(current.value)}); to line 269, as part of the removeItem method.

Will wait for your PR if you're up for it?