-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels cannot be removed from an execution #6205
Comments
Also, as @loicmathieu worked on labels few days ago, maybe he can give us some hints here. |
Hi @loicmathieu, Can you assign this to me? |
I can assign you, but this might be a bit tricky to do, as we need to change a behavior a bit more than described here. May I suggest that you check our curated list of good first issues to see if there is something you find interesting enough and think you can tackle independently. It can be further filtered by desired labels to narrow down the results (suggesting to filter by either |
Hi @MilosPaunovic , I see, actually I did go through it yesterday and I kind of found the issue, as if we remove it from the frontend it get removed successfully and sent to the backend, the issue is that all labels is saved in one variable in the backend and the function that update the labels always go through the saved labels in the backend and add them again. I do not get it why it is built like that. |
Anyway if you believe it is a bit complex I will look for a different issue. |
Still valide on preview env as 21/01/2025 |
Hey, @MilosPaunovic |
Absolutely, go for it @Malaydewangan09! 🚀 |
Hey, @MilosPaunovic
Removing the condition resolves the issue. |
@loicmathieu We'd need your input here. |
Hey @loicmathieu , just following up. Let me know when you get a chance. |
@Malaydewangan09 I'm not sure which condition you are talking about so the best would be to craft a reproducer as a unit test and to open a PR that fixes it. |
Sure @loicmathieu |
I've removed the necessary restriction for label removal on the |
Describe the issue
In the execution view,
Set labels
, removing a label doesn't workEnvironment
The text was updated successfully, but these errors were encountered: