Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard during loading should not display no data #6469

Open
tchiotludo opened this issue Dec 15, 2024 · 5 comments · May be fixed by #7417
Open

Dashboard during loading should not display no data #6469

tchiotludo opened this issue Dec 15, 2024 · 5 comments · May be fixed by #7417
Assignees
@MilosPaunovic @Piyush-r-bhaskar
Labels
area/frontend Needs frontend code changes bug Something isn't working good first issue Great issue for new contributors kind/quick-win Seems to be quick to do

Comments

@tchiotludo
Copy link
Member

image

So far, we are displaying no data during loading, we should display a loading version to avoid confusion
@tchiotludo tchiotludo added bug Something isn't working area/frontend Needs frontend code changes labels Dec 15, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Issues Dec 15, 2024
@Karthik73965
Copy link
Contributor

Can I work on this issue ?

@MilosPaunovic
Copy link
Member

Absolutely, go for it @Karthik73965! 🚀

@Karthik73965 Karthik73965 mentioned this issue Dec 29, 2024
Merged
@Karthik73965
Copy link
Contributor

@MilosPaunovic I raised a pr please check that out ! 🚀

@MilosPaunovic MilosPaunovic moved this from Backlog to In review in Issues Jan 16, 2025
@MilosPaunovic
Copy link
Member

MilosPaunovic commented Feb 4, 2025 •
edited
Loading

Hi @Karthik73965, as there were no recent activity on the PR, I've amended what was possible and merged - now we have loading skeletons for the top four cards on the Dashboard page.

What's left to be done here is adding the loading states to the charts - it's up for grabs if someone else form the community wants to give it a try.

@MilosPaunovic MilosPaunovic moved this from In review to Backlog in Issues Feb 4, 2025
@MilosPaunovic MilosPaunovic added the good first issue Great issue for new contributors label Feb 4, 2025
@anna-geller anna-geller added the kind/quick-win Seems to be quick to do label Feb 13, 2025
@Piyush-r-bhaskar Piyush-r-bhaskar linked a pull request Feb 15, 2025 that will close this issue
Open
@Piyush-r-bhaskar
Copy link
Contributor

What's left to be done here is adding the loading states to the charts - it's up for grabs if someone else form the community wants to give it a try.

I tried to do this also and opened PR for your review @MilosPaunovic

@MilosPaunovic MilosPaunovic moved this from Backlog to In review in Issues Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MilosPaunovic MilosPaunovic

@Piyush-r-bhaskar Piyush-r-bhaskar

Labels
area/frontend Needs frontend code changes bug Something isn't working good first issue Great issue for new contributors kind/quick-win Seems to be quick to do
Projects
Issues
Status: In review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui): skeletons based on type like for chart and table. Piyush-r-bhaskar/kestra_5586
5 participants
@tchiotludo @MilosPaunovic @anna-geller @Piyush-r-bhaskar @Karthik73965