Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Allow defining triggers directly from the Flow/Trigger tab instead of editing the YAML flow #3288

Open
fhussonnois opened this issue Mar 15, 2024 · 4 comments · May be fixed by #7754
Open
Assignees
Labels
area/frontend Needs frontend code changes enhancement New feature or request good first issue Great issue for new contributors kind/quick-win Seems to be quick to do

Comments

@fhussonnois
Copy link
Member

Feature description

Currently, if the users want to add a trigger to a new or existing flow, for example, they need to do so via the YAML editor. We should provide a friendly UI (more basically a form) to do it from the Trigger tab. This will help users to more easily discover the available triggers and their options. Eventually, we could add an /PATH API to be able to add a trigger to an existing flow without the need to push back the entire flow definition. In that way, adding a trigger through the Trigger API will lead to a new flow revision.

@fhussonnois fhussonnois added area/backend Needs backend code changes enhancement New feature or request area/frontend Needs frontend code changes labels Mar 15, 2024
@anna-geller
Copy link
Member

anna-geller commented Mar 15, 2024

We could add a button here, something like "Add a trigger"

image

And this would then navigate to the Code Editor with the form open on the right with the option to select a trigger equivalent to this option

image

image

Would it satisfy the user's request? (seems like a good idea to make that empty trigger table more actionable)

@anna-geller anna-geller added this to the v0.16.0 milestone Mar 15, 2024
@anna-geller anna-geller added the kind/quick-win Seems to be quick to do label Mar 15, 2024
@fhussonnois
Copy link
Member Author

@anna-geller,I'm sorry, I just realized that there's already a panel for adding triggers from the Editor/Actions button. But, this one is not very visible. I think your proposal to add a new button to the trigger tab is sufficient.

@anna-geller anna-geller removed the area/backend Needs backend code changes label Mar 15, 2024
@anna-geller anna-geller modified the milestones: v0.16.0, v0.22.0 Apr 3, 2024
@MilosPaunovic MilosPaunovic self-assigned this May 28, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Issues Jun 10, 2024
@anna-geller anna-geller removed this from the v0.22.0 milestone Jul 23, 2024
@tchiotludo tchiotludo added good first issue Great issue for new contributors and removed kind/good-first-issue labels Oct 1, 2024
@MilosPaunovic MilosPaunovic removed their assignment Oct 16, 2024
@Piyush-r-bhaskar
Copy link
Contributor

Hey All,

I will check this.

I would like to proceed as: Would this be fine with new changes to flow ?

  • A Add Trigger button on Empty screen of Triggers tab.
  • A Add Trigger button below the table if triggersWithType.length .

These buttons should switch editor to NO_CODE (similar to when we try to Edit from Topology) to add trigger from below

Image

@anna-geller
Copy link
Member

sounds good

These buttons should switch editor to NO_CODE

keep in mind this will change fairly soon as we are revamping the Code vs No-Code Editor tabs, but for now we can do it as you described 👍

@Piyush-r-bhaskar Piyush-r-bhaskar linked a pull request Mar 8, 2025 that will close this issue
@MilosPaunovic MilosPaunovic moved this from Backlog to In review in Issues Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Needs frontend code changes enhancement New feature or request good first issue Great issue for new contributors kind/quick-win Seems to be quick to do
Projects
Status: In review
Development

Successfully merging a pull request may close this issue.

5 participants