Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double-dot Vignette #52

Closed
assignUser opened this issue Sep 25, 2020 · 6 comments
Closed

double-dot Vignette #52

assignUser opened this issue Sep 25, 2020 · 6 comments
Labels
docs an issue concerning the documentation
Milestone

Comments

@assignUser
Copy link
Collaborator

once #41 #46 are closed: create vignette explaining the new formula system and multi core ability.

@assignUser assignUser added the docs an issue concerning the documentation label Sep 25, 2020
@assignUser assignUser added this to the 0.2.0 milestone Sep 25, 2020
@kgoldfeld
Copy link
Owner

I'll likely write the vignette once #59 is done. If it is in time for my next scheduled blog post (October 13th), I will post it there - or some version of it. I will also let folks know that a new release is imminent - if it hasn't already happened yet.

@kgoldfeld
Copy link
Owner

Take a look at the new vignette in the vignette branch. If I have left out anything major (or minor) or anything is not clear, feel free to edit or let me know, and I can edit. (I also found and fixed a small bug in the updateDef functions that has been there since I created it.)

@assignUser
Copy link
Collaborator Author

Yeah looks nice. I think it shows off the features but in a easy to understand way, power users will see the potential immediately anyway 😁 , I added a missing "in" and put the correct name name of the vignette into the news.

@kgoldfeld
Copy link
Owner

Great - I am merging.

So, two questions for you

(1) are we just just about ready to submit version 0.2.0? It looks all of our milestones are met.

(2) if we are going to submit to CRAN, I definitely want to make an announcement on my blog, and then introduce the double-dot notation - I will basically use the vignette. I know that you are careful about releasing your name online, so I was wondering if it would be OK if I mentioned you in the blog post. Let me know - and I will identify you any way you'd like (e.g. name, institutional affiliation, etc.)

@assignUser
Copy link
Collaborator Author

  1. I'd like to fix the trtAssign bug trtAssign fails when strata has count of one #19 and look over pass-by-value vs. pass-by-reference #50 before we start the release process but other than that I think we are ready 👍
  2. I decided to be public with this account & simstudy as I think it is a worthy pursuit :) So feel free to mention me in anyway you like with the information in the description (ORCID etc.) I am not sure on the etiquette of affiliation. Should we name my institution even though my role there is not related to simstudy?

@kgoldfeld
Copy link
Owner

Sounds great. And I'll use your name but no institutional affiliation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs an issue concerning the documentation
Projects
None yet
Development

No branches or pull requests

2 participants