Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.mokuro not including cover pages #106

Open
zenithilia opened this issue Jul 9, 2024 · 3 comments
Open

.mokuro not including cover pages #106

zenithilia opened this issue Jul 9, 2024 · 3 comments

Comments

@zenithilia
Copy link

I tried using mokuro on a bunch of manga and it always ignored the cover pages, as the json files exist but they're not... added? inside of the html and .mokuro. It does not create any problem with the html files (just the cover(s) missing), but it does create issues with the online reader shifting all the texts a bunch of pages behind.

I have no idea if I'm doing something wrong, if it's a bug or if it's a normal behaviour of the app.

@kha-white
Copy link
Owner

Could you upload an example? Can be just a few pages for which it fails.

@zenithilia
Copy link
Author

zenithilia commented Jul 10, 2024

I did some more tests today and I think I found what goes wrong. When the cover is named differently than the pages, like "!Cover_xxx", the cover page(s) seemed to get shifted to the end, which does not cause problems in the HTML version, but it does cause all transcriptions to be shifted by the amount of cover pages, as the .mokuro considers the covers to be at the end but the online reader puts the images in their normal order. If all the pages follow a normal naming order, the problem seems to disappear and everything works as expected.

An example where the problem happens
image
image
image
image
The same example with all the files following the same naming scheme
image
image
image

If needed, here are the files for this example

I don't know if it's a bug or not, and if it is I don't know if it can be fixed or not, but hopefully this could answer people who'd run into the same problem

@kha-white
Copy link
Owner

Mismatch is caused by mokuro reader, I created an issue in its repository.

On mokuro side, sorting is done with natsort library, which by default puts special characters after numbers, in this case putting the cover page after normal pages. natsort.os_sorted on Windows sorts the same way as Windows Explorer, so ! would be before numbers, but I don't like how the results will be different depending on the OS. Not sure what the best solution would be here, if using special characters for cover pages is more common than maybe a special case for sorting is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants