refactor: ✨ move netlify functions folder

Author: kien-ht

netlify.toml

@@ -2,3 +2,11 @@
   from = "/*"
   to = "/index.html"
   status = 200
+
+[functions]
+  directory = "/src/github-app-server/functions"
+
+[build]
+  ignore = "git diff --quiet $CACHED_COMMIT_REF $COMMIT_REF src/github-app-server src/common src/ui package.json netlify.toml"
+  publish = "dist/ui"
+  command = "npm run build:ci"

src/common/utils.ts

@@ -11,8 +11,7 @@ import {
   GenerateInlineConfig,
   StartInlineConfig,
   RunMode,
-  InjectedData,
-  ProbotLogLevel
+  InjectedData
 } from './types.js'
 import { DEFAULT_CONFIG, DEFAULT_CONFIG_PATH } from './constants.js'
 import { __dirname, dynamicImport } from './utils-cjs.js'
@@ -234,12 +233,3 @@ async function getLatestJsonFromDir(dir: string): Promise<string | undefined> {
     throw Error((err as Error).message)
   }
 }
-
-export function getProbotConfig() {
-  return {
-    appId: process.env.APP_ID!,
-    privateKey: process.env.PRIVATE_KEY!,
-    secret: process.env.WEBHOOK_SECRET!,
-    logLevel: process.env.LOG_LEVEL! as ProbotLogLevel
-  }
-}

src/github-ci-server/controller.ts renamed to src/github-app-server/controller.ts

@@ -7,13 +7,11 @@ import {
   Report,
   DownloadArtifactsOptions,
   GetSnapshotsHashed,
-  HashedSnapshotToUpdate
+  HashedSnapshotToUpdate,
+  ProbotLogLevel
 } from '../common/types.js'
 import { App as OctokitApp, Octokit } from 'octokit'
-import {
-  getProbotConfig,
-  getReportJsonWithTotalStats
-} from '../common/utils.js'
+import { getReportJsonWithTotalStats } from '../common/utils.js'
 
 export class CiController {
   private app: OctokitApp
@@ -106,7 +104,16 @@ export async function downloadArtifacts(
   return JSON.parse(report.getData().toString())
 }
 
-export async function getSnapshotsHashes(
+function getProbotConfig() {
+  return {
+    appId: process.env.APP_ID!,
+    privateKey: process.env.PRIVATE_KEY!,
+    secret: process.env.WEBHOOK_SECRET!,
+    logLevel: process.env.LOG_LEVEL! as ProbotLogLevel
+  }
+}
+
+async function getSnapshotsHashes(
   { owner, repo, snapshots }: GetSnapshotsHashed,
   octokit: Octokit | ProbotOctokit
 ): Promise<HashedSnapshotToUpdate[]> {

netlify/functions/api.ts renamed to src/github-app-server/functions/api.ts

@@ -1,7 +1,7 @@
 import { Handler } from '@netlify/functions'
-import { UpdateBaselines, WorkflowInstance } from '../../src/common/types'
-import { CiController } from '../../src/github-ci-server/controller'
-import { PATH_TO_SERVERLESS_FUNCTIONS } from '../../src/common/constants'
+import { UpdateBaselines, WorkflowInstance } from '../../common/types'
+import { CiController } from '../controller'
+import { PATH_TO_SERVERLESS_FUNCTIONS } from '../../common/constants'
 
 // Replace escaped newlines to fix this octokit bug
 // Error: secretOrPrivateKey must be an asymmetric key when using RS256

netlify/functions/github-marketplace.ts renamed to src/github-app-server/functions/github-marketplace.ts

@@ -3,7 +3,7 @@ import {
   createProbot,
   ApplicationFunction
 } from '@probot/adapter-aws-lambda-serverless'
-import { appFn } from '../../src/github-ci-server/webhook'
+import { appFn } from '../probot-app'
 
 // Replace escaped newlines to fix this octokit bug
 // Error: secretOrPrivateKey must be an asymmetric key when using RS256

netlify/functions/webhooks.ts renamed to src/github-app-server/functions/webhooks.ts

@@ -52,8 +52,7 @@ export default defineConfig(async ({ mode }): Promise<UserConfig> => {
     publicDir: mode === 'development' ? '../../playground' : false,
 
     build: {
-      outDir:
-        process.env.RUN_MODE === 'ci' ? '../../dist-ci/ui' : '../../dist/ui',
+      outDir: '../../dist/ui',
       emptyOutDir: true
     },