preliminary work for external tx support

Author: wighawag

TODO.md

@@ -20,3 +20,4 @@
 - [ ] error on Library missing in bytecode
 - [ ] error when not finding --no-scripts as folder
 - [ ] continue even if evm_snapshot not present on fixture call
+- [ ] supports ENS name in namedAccounts (fetch ENS first, or only if ends with .eth or other domain?, require mainnet provider)

src/helpers.ts

@@ -614,11 +614,11 @@ export function addHelpers(
     );
     await setupGasPrice(unsignedTx);
     await setupNonce(from, unsignedTx);
- 
+
     // Temporary workaround for https://github.com/ethers-io/ethers.js/issues/2078
     // TODO: Remove me when LedgerSigner adds proper support for 1559 txns
     if (hardwareWallet === 'ledger') {
-      unsignedTx.type = 1
+      unsignedTx.type = 1;
     }
 
     if (unknown) {
@@ -1730,7 +1730,26 @@ Note that in this case, the contract deployment will not behave the same if depl
         const registeredProtocol =
           deploymentManager.addressesToProtocol[from.toLowerCase()];
         if (registeredProtocol) {
-          if (registeredProtocol === 'ledger') {
+          if (registeredProtocol === 'external') {
+            ethersSigner = provider.getSigner(from); //new WaitingTxSigner(from, provider);
+            ethersSigner.sendTransaction = async (
+              txRequest: TransactionRequest
+            ) => {
+              const response: {hash: string} = await enquirer.prompt({
+                type: 'input',
+                name: 'hash',
+                message: `
+                tx hash please
+                to : ${txRequest.to}
+                data : ${txRequest.data}
+                value : ${txRequest.value}
+                `,
+              });
+
+              return provider.getTransaction(response.hash);
+            };
+            hardwareWallet = 'external';
+          } else if (registeredProtocol === 'ledger') {
             if (!LedgerSigner) {
               // eslint-disable-next-line @typescript-eslint/no-unused-vars
               let error: any | undefined;

src/utils.ts

@@ -68,7 +68,10 @@ export async function getExtendedArtifactFromFolders(
   for (const folderPath of folderPaths) {
     const artifacts = new Artifacts(folderPath);
     let artifact = getOldArtifactSync(name, folderPath);
-    if (!artifact && (await artifacts.artifactExists(name).catch(()=>false))) {
+    if (
+      !artifact &&
+      (await artifacts.artifactExists(name).catch(() => false))
+    ) {
       const hardhatArtifact: Artifact = await artifacts.readArtifact(name);
       // check if name is already a fullyQualifiedName
       let fullyQualifiedName = name;
@@ -332,7 +335,12 @@ function transformNamedAccounts(
           // eslint-disable-next-line no-case-declarations
           const protocolSplit = spec.split('://');
           if (protocolSplit.length > 1) {
-            if (protocolSplit[0].toLowerCase() === 'ledger') {
+            if (protocolSplit[0].toLowerCase() === 'external') {
+              address = protocolSplit[1];
+              addressesToProtocol[address.toLowerCase()] =
+                protocolSplit[0].toLowerCase();
+              // knownAccountsDict[address.toLowerCase()] = true; // TODO ? this would prevent auto impersonation in fork/test
+            } else if (protocolSplit[0].toLowerCase() === 'ledger') {
               address = protocolSplit[1];
               addressesToProtocol[address.toLowerCase()] =
                 protocolSplit[0].toLowerCase();