From d19b3f01fdb77fdf7d70ad54141ed89976cd60ab Mon Sep 17 00:00:00 2001 From: Tishasoumya-02 Date: Fri, 3 Jul 2026 13:53:20 +0530 Subject: [PATCH 01/12] use clickable_profile instead of disable --- backend/src/kitconcept/core/controlpanel/kitconcept.py | 8 ++++---- docs/docs/concepts/what-is-core.md | 2 +- docs/docs/how-to-guides/upgrade-plone.md | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/backend/src/kitconcept/core/controlpanel/kitconcept.py b/backend/src/kitconcept/core/controlpanel/kitconcept.py index d76a1724..7313331c 100644 --- a/backend/src/kitconcept/core/controlpanel/kitconcept.py +++ b/backend/src/kitconcept/core/controlpanel/kitconcept.py @@ -21,10 +21,10 @@ class IKitconceptSettings(Interface): required=False, ) - disable_profile_links = schema.Bool( - title=_("Non-clickable Profiles"), + clickable_profile_links = schema.Bool( + title=_("Clickable profiles"), description=_( - "Person profiles are not clickable in teasers, grids, listings, and search" + "Person profiles are clickable in teasers, grids, listings, and search" ), required=False, default=False, @@ -68,4 +68,4 @@ def __call__(self, data): IKitconceptSettings, prefix="kitconcept.core.settings" ) data["kitconcept.custom_css"] = settings.custom_css - data["kitconcept.disable_profile_links"] = settings.disable_profile_links + data["kitconcept.clickable_profile_links"] = settings.clickable_profile_links diff --git a/docs/docs/concepts/what-is-core.md b/docs/docs/concepts/what-is-core.md index 72a19dfb..56280720 100644 --- a/docs/docs/concepts/what-is-core.md +++ b/docs/docs/concepts/what-is-core.md @@ -110,7 +110,7 @@ After bumping the version of `kitconcept.core:base`, we need to create a new upg handler="..utils.null_upgrade_step" /> diff --git a/docs/docs/how-to-guides/upgrade-plone.md b/docs/docs/how-to-guides/upgrade-plone.md index 48ae0733..89be4cc7 100644 --- a/docs/docs/how-to-guides/upgrade-plone.md +++ b/docs/docs/how-to-guides/upgrade-plone.md @@ -49,7 +49,7 @@ Make a quick search for `plone_version` in the `backend/tests` folder and update /> From 6b96e0894eae56cea9348878b8a19123cad2198a Mon Sep 17 00:00:00 2001 From: Tishasoumya-02 Date: Mon, 6 Jul 2026 11:05:51 +0530 Subject: [PATCH 02/12] Default to True for clickable profile --- backend/src/kitconcept/core/controlpanel/kitconcept.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backend/src/kitconcept/core/controlpanel/kitconcept.py b/backend/src/kitconcept/core/controlpanel/kitconcept.py index 7313331c..71075111 100644 --- a/backend/src/kitconcept/core/controlpanel/kitconcept.py +++ b/backend/src/kitconcept/core/controlpanel/kitconcept.py @@ -27,7 +27,7 @@ class IKitconceptSettings(Interface): "Person profiles are clickable in teasers, grids, listings, and search" ), required=False, - default=False, + default=True, ) From a70ded2d8ce282c2c25c635820c98d6d3af12ded Mon Sep 17 00:00:00 2001 From: Tishasoumya-02 Date: Mon, 6 Jul 2026 11:30:49 +0530 Subject: [PATCH 03/12] changelog --- backend/news/+updateDisabletoClickableProfileLink.bugfix | 1 + 1 file changed, 1 insertion(+) create mode 100644 backend/news/+updateDisabletoClickableProfileLink.bugfix diff --git a/backend/news/+updateDisabletoClickableProfileLink.bugfix b/backend/news/+updateDisabletoClickableProfileLink.bugfix new file mode 100644 index 00000000..886f5788 --- /dev/null +++ b/backend/news/+updateDisabletoClickableProfileLink.bugfix @@ -0,0 +1 @@ +Use "clickable_profile_link' instead of 'disable_profile_link' @Tishasoumya-02 \ No newline at end of file From 552dd640f3229cdc7736f0555bbc3d4b9175cc8c Mon Sep 17 00:00:00 2001 From: Tishasoumya-02 Date: Mon, 6 Jul 2026 18:40:40 +0530 Subject: [PATCH 04/12] upgrade step --- .../kitconcept/core/upgrades/configure.zcml | 1 + backend/src/kitconcept/core/upgrades/utils.py | 22 ++++++++++++++++++ .../core/upgrades/v20260706001/__init__.py | 0 .../core/upgrades/v20260706001/configure.zcml | 23 +++++++++++++++++++ 4 files changed, 46 insertions(+) create mode 100644 backend/src/kitconcept/core/upgrades/v20260706001/__init__.py create mode 100644 backend/src/kitconcept/core/upgrades/v20260706001/configure.zcml diff --git a/backend/src/kitconcept/core/upgrades/configure.zcml b/backend/src/kitconcept/core/upgrades/configure.zcml index 60b9c20c..60e2ec77 100644 --- a/backend/src/kitconcept/core/upgrades/configure.zcml +++ b/backend/src/kitconcept/core/upgrades/configure.zcml @@ -14,5 +14,6 @@ + diff --git a/backend/src/kitconcept/core/upgrades/utils.py b/backend/src/kitconcept/core/upgrades/utils.py index a1dd5375..a3379bf8 100644 --- a/backend/src/kitconcept/core/upgrades/utils.py +++ b/backend/src/kitconcept/core/upgrades/utils.py @@ -1,8 +1,30 @@ from kitconcept.core import logger +from plone.registry.interfaces import IRegistry from Products.GenericSetup.tool import SetupTool +from zope.component import getUtility def null_upgrade_step(tool: SetupTool): """This is a null upgrade, use it when nothing happens""" logger.info("Null migration step.") pass + + +def rename_disable_to_clickable_profile_links(tool: SetupTool): + """Migrate disable_profile_links to clickable_profile_links. + + The old ``disable_profile_links`` flag was inverted and renamed to + ``clickable_profile_links``, so carry the previous value over with the + opposite meaning and drop the stale record. + """ + old_key = "kitconcept.core.settings.disable_profile_links" + new_key = "kitconcept.core.settings.clickable_profile_links" + registry = getUtility(IRegistry) + records = registry.records + if old_key in records: + disabled = registry[old_key] + registry[new_key] = not disabled + del records[old_key] + logger.info(f"Migrated {old_key}={disabled} to {new_key}={not disabled}") + else: + logger.info(f"{old_key} not present, nothing to migrate.") diff --git a/backend/src/kitconcept/core/upgrades/v20260706001/__init__.py b/backend/src/kitconcept/core/upgrades/v20260706001/__init__.py new file mode 100644 index 00000000..e69de29b diff --git a/backend/src/kitconcept/core/upgrades/v20260706001/configure.zcml b/backend/src/kitconcept/core/upgrades/v20260706001/configure.zcml new file mode 100644 index 00000000..135055ef --- /dev/null +++ b/backend/src/kitconcept/core/upgrades/v20260706001/configure.zcml @@ -0,0 +1,23 @@ + + + + + + + + From 396a8b377dd2462337e0136a4d8cca5813f29889 Mon Sep 17 00:00:00 2001 From: Tishasoumya-02 Date: Thu, 9 Jul 2026 12:03:47 +0530 Subject: [PATCH 05/12] fix the upgrade steps --- backend/src/kitconcept/core/upgrades/utils.py | 22 ------------------- .../core/upgrades/v20260706001/__init__.py | 20 +++++++++++++++++ .../core/upgrades/v20260706001/configure.zcml | 7 +++--- 3 files changed, 23 insertions(+), 26 deletions(-) diff --git a/backend/src/kitconcept/core/upgrades/utils.py b/backend/src/kitconcept/core/upgrades/utils.py index a3379bf8..a1dd5375 100644 --- a/backend/src/kitconcept/core/upgrades/utils.py +++ b/backend/src/kitconcept/core/upgrades/utils.py @@ -1,30 +1,8 @@ from kitconcept.core import logger -from plone.registry.interfaces import IRegistry from Products.GenericSetup.tool import SetupTool -from zope.component import getUtility def null_upgrade_step(tool: SetupTool): """This is a null upgrade, use it when nothing happens""" logger.info("Null migration step.") pass - - -def rename_disable_to_clickable_profile_links(tool: SetupTool): - """Migrate disable_profile_links to clickable_profile_links. - - The old ``disable_profile_links`` flag was inverted and renamed to - ``clickable_profile_links``, so carry the previous value over with the - opposite meaning and drop the stale record. - """ - old_key = "kitconcept.core.settings.disable_profile_links" - new_key = "kitconcept.core.settings.clickable_profile_links" - registry = getUtility(IRegistry) - records = registry.records - if old_key in records: - disabled = registry[old_key] - registry[new_key] = not disabled - del records[old_key] - logger.info(f"Migrated {old_key}={disabled} to {new_key}={not disabled}") - else: - logger.info(f"{old_key} not present, nothing to migrate.") diff --git a/backend/src/kitconcept/core/upgrades/v20260706001/__init__.py b/backend/src/kitconcept/core/upgrades/v20260706001/__init__.py index e69de29b..0a45a545 100644 --- a/backend/src/kitconcept/core/upgrades/v20260706001/__init__.py +++ b/backend/src/kitconcept/core/upgrades/v20260706001/__init__.py @@ -0,0 +1,20 @@ +from plone.registry.interfaces import IRegistry +from Products.GenericSetup.tool import SetupTool +from zope.component import getUtility + + +def rename_disable_to_clickable_profile_links(tool: SetupTool): + """Migrate disable_profile_links to clickable_profile_links. + + The old ``disable_profile_links`` flag was inverted and renamed to + ``clickable_profile_links``, so carry the previous value over with the + opposite meaning and drop the stale record. + """ + old_key = "kitconcept.core.settings.disable_profile_links" + new_key = "kitconcept.core.settings.clickable_profile_links" + registry = getUtility(IRegistry) + records = registry.records + if old_key in records: + disabled = registry[old_key] + registry[new_key] = not disabled + del records[old_key] diff --git a/backend/src/kitconcept/core/upgrades/v20260706001/configure.zcml b/backend/src/kitconcept/core/upgrades/v20260706001/configure.zcml index 135055ef..26b040a4 100644 --- a/backend/src/kitconcept/core/upgrades/v20260706001/configure.zcml +++ b/backend/src/kitconcept/core/upgrades/v20260706001/configure.zcml @@ -9,14 +9,13 @@ destination="20260706001" > From 735f805dde6225cc8f273d3883ba0a2c9d616e55 Mon Sep 17 00:00:00 2001 From: Tishasoumya-02 Date: Thu, 9 Jul 2026 12:06:01 +0530 Subject: [PATCH 06/12] fix --- backend/src/kitconcept/core/upgrades/v20260706001/configure.zcml | 1 + 1 file changed, 1 insertion(+) diff --git a/backend/src/kitconcept/core/upgrades/v20260706001/configure.zcml b/backend/src/kitconcept/core/upgrades/v20260706001/configure.zcml index 26b040a4..0b676efb 100644 --- a/backend/src/kitconcept/core/upgrades/v20260706001/configure.zcml +++ b/backend/src/kitconcept/core/upgrades/v20260706001/configure.zcml @@ -10,6 +10,7 @@ > From 0f8530847dc4609c9384edb8a3a14c6afe511cb9 Mon Sep 17 00:00:00 2001 From: Tishasoumya-02 Date: Thu, 9 Jul 2026 17:39:52 +0530 Subject: [PATCH 07/12] fix lint --- backend/src/kitconcept/core/upgrades/configure.zcml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backend/src/kitconcept/core/upgrades/configure.zcml b/backend/src/kitconcept/core/upgrades/configure.zcml index 4846b124..c32602b8 100644 --- a/backend/src/kitconcept/core/upgrades/configure.zcml +++ b/backend/src/kitconcept/core/upgrades/configure.zcml @@ -16,5 +16,5 @@ - + From f0a4b00bdef15dfb8c0a8ce2b7bb377e6713a348 Mon Sep 17 00:00:00 2001 From: Tishasoumya-02 Date: Thu, 9 Jul 2026 17:51:23 +0530 Subject: [PATCH 08/12] fix test --- backend/tests/conftest.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backend/tests/conftest.py b/backend/tests/conftest.py index c2a634d4..78d44ea8 100644 --- a/backend/tests/conftest.py +++ b/backend/tests/conftest.py @@ -67,7 +67,7 @@ def current_versions() -> CurrentVersions: from kitconcept.core import __version__ return CurrentVersions( - base="20260701001", + base="20260706001", dependencies="1000", package=__version__, ) From 146c93fdf0c67cff46b752f9ce9a326f277f6902 Mon Sep 17 00:00:00 2001 From: Tishasoumya-02 Date: Thu, 9 Jul 2026 17:57:24 +0530 Subject: [PATCH 09/12] Add documentation news fragment for docs changes Co-Authored-By: Claude Opus 4.8 --- news/+clickableProfileLink.documentation | 1 + 1 file changed, 1 insertion(+) create mode 100644 news/+clickableProfileLink.documentation diff --git a/news/+clickableProfileLink.documentation b/news/+clickableProfileLink.documentation new file mode 100644 index 00000000..56bae147 --- /dev/null +++ b/news/+clickableProfileLink.documentation @@ -0,0 +1 @@ +Update docs for clickable profile link control panel setting @Tishasoumya-02 From c5a06b00c3609420560482de587614903c926ff8 Mon Sep 17 00:00:00 2001 From: Tishasoumya-02 Date: Thu, 9 Jul 2026 18:05:57 +0530 Subject: [PATCH 10/12] fix --- .../src/kitconcept/core/upgrades/v20260706001/configure.zcml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backend/src/kitconcept/core/upgrades/v20260706001/configure.zcml b/backend/src/kitconcept/core/upgrades/v20260706001/configure.zcml index 5d9693cd..9b0c3e41 100644 --- a/backend/src/kitconcept/core/upgrades/v20260706001/configure.zcml +++ b/backend/src/kitconcept/core/upgrades/v20260706001/configure.zcml @@ -9,7 +9,7 @@ destination="20260706001" > From ab413b1acdddd03442375bb45d4d685537b548c5 Mon Sep 17 00:00:00 2001 From: Tishasoumya-02 Date: Fri, 10 Jul 2026 17:06:26 +0530 Subject: [PATCH 11/12] fix toast i size --- .../src/theme/components/returnToOriginal.scss | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/frontend/packages/kitconcept-core/src/theme/components/returnToOriginal.scss b/frontend/packages/kitconcept-core/src/theme/components/returnToOriginal.scss index 4d52d401..c369fd1c 100644 --- a/frontend/packages/kitconcept-core/src/theme/components/returnToOriginal.scss +++ b/frontend/packages/kitconcept-core/src/theme/components/returnToOriginal.scss @@ -1,6 +1,11 @@ -.Toastify__toast.Toastify__toast--info.return-to-origin-toast +.Toastify__toast.Toastify__toast--info.return-to-origin-toast { .toast-box-center { - padding-top: 20px; + padding-top: 20px; + } + + .Toastify__toast-body svg.icon { + height: 28px !important; + } } .return.toast-box { From e0c24f17a30c09cfd5add057f6416ab0d7675f2a Mon Sep 17 00:00:00 2001 From: Tishasoumya-02 Date: Fri, 10 Jul 2026 20:30:39 +0530 Subject: [PATCH 12/12] changelog --- frontend/packages/kitconcept-core/news/+fixToast_i_icon.bugfix | 1 + 1 file changed, 1 insertion(+) create mode 100644 frontend/packages/kitconcept-core/news/+fixToast_i_icon.bugfix diff --git a/frontend/packages/kitconcept-core/news/+fixToast_i_icon.bugfix b/frontend/packages/kitconcept-core/news/+fixToast_i_icon.bugfix new file mode 100644 index 00000000..f8c0fabf --- /dev/null +++ b/frontend/packages/kitconcept-core/news/+fixToast_i_icon.bugfix @@ -0,0 +1 @@ +Fix the size of i icon in toast @Tishasoumya-02 \ No newline at end of file